Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
李少辉-开发者
gitlab-foss
提交
c08a14c3
G
gitlab-foss
项目概览
李少辉-开发者
/
gitlab-foss
通知
15
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
G
gitlab-foss
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
c08a14c3
编写于
8月 03, 2016
作者:
D
Douglas Barbosa Alexandre
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Removes all list-labels when moving to Backlog/Done
上级
9e5a305f
变更
2
显示空白变更内容
内联
并排
Showing
2 changed file
with
26 addition
and
11 deletion
+26
-11
app/services/boards/issues/move_service.rb
app/services/boards/issues/move_service.rb
+17
-2
spec/services/boards/issues/move_service_spec.rb
spec/services/boards/issues/move_service_spec.rb
+9
-9
未找到文件。
app/services/boards/issues/move_service.rb
浏览文件 @
c08a14c3
...
...
@@ -45,10 +45,25 @@ module Boards
def
issue_params
{
add_label_ids:
[
moving_to
.
label_id
].
compact
,
remove_label_ids:
[
moving_from
.
label_id
].
compact
add_label_ids:
add_label_ids
,
remove_label_ids:
remove_label_ids
}
end
def
add_label_ids
[
moving_to
.
label_id
].
compact
end
def
remove_label_ids
label_ids
=
if
moving_to
.
label?
moving_from
.
label_id
else
board
.
lists
.
label
.
pluck
(
:label_id
)
end
Array
(
label_ids
).
compact
end
end
end
end
spec/services/boards/issues/move_service_spec.rb
浏览文件 @
c08a14c3
...
...
@@ -10,10 +10,10 @@ describe Boards::Issues::MoveService, services: true do
let
(
:development
)
{
create
(
:label
,
project:
project
,
name:
'Development'
)
}
let
(
:testing
)
{
create
(
:label
,
project:
project
,
name:
'Testing'
)
}
let
(
:backlog
)
{
create
(
:backlog_list
,
board:
board
)
}
let
(
:list1
)
{
create
(
:list
,
board:
board
,
label:
development
,
position:
0
)
}
let
(
:list2
)
{
create
(
:list
,
board:
board
,
label:
testing
,
position:
1
)
}
let
(
:done
)
{
create
(
:done_list
,
board:
board
)
}
let
!
(
:backlog
)
{
create
(
:backlog_list
,
board:
board
)
}
let
!
(
:list1
)
{
create
(
:list
,
board:
board
,
label:
development
,
position:
0
)
}
let
!
(
:list2
)
{
create
(
:list
,
board:
board
,
label:
testing
,
position:
1
)
}
let
!
(
:done
)
{
create
(
:done_list
,
board:
board
)
}
before
do
project
.
team
<<
[
user
,
:developer
]
...
...
@@ -31,8 +31,8 @@ describe Boards::Issues::MoveService, services: true do
end
context
'when moving to backlog'
do
it
'remove
the label of the list it came from
'
do
issue
=
create
(
:labeled_issue
,
project:
project
,
labels:
[
bug
,
development
])
it
'remove
s all list-labels
'
do
issue
=
create
(
:labeled_issue
,
project:
project
,
labels:
[
bug
,
development
,
testing
])
params
=
{
id:
issue
.
iid
,
from:
list1
.
id
,
to:
backlog
.
id
}
described_class
.
new
(
project
,
user
,
params
).
execute
...
...
@@ -64,7 +64,7 @@ describe Boards::Issues::MoveService, services: true do
described_class
.
new
(
project
,
user
,
params
).
execute
end
it
'removes the label from the list it came from and adds the label of the list it goes to'
do
it
'removes
s
the label from the list it came from and adds the label of the list it goes to'
do
described_class
.
new
(
project
,
user
,
params
).
execute
expect
(
issue
.
reload
.
labels
).
to
contain_exactly
(
bug
,
testing
)
...
...
@@ -72,7 +72,7 @@ describe Boards::Issues::MoveService, services: true do
end
context
'when moving to done'
do
let
(
:issue
)
{
create
(
:labeled_issue
,
project:
project
,
labels:
[
bug
,
testing
])
}
let
(
:issue
)
{
create
(
:labeled_issue
,
project:
project
,
labels:
[
bug
,
development
,
testing
])
}
let
(
:params
)
{
{
id:
issue
.
iid
,
from:
list2
.
id
,
to:
done
.
id
}
}
it
'delegates the close proceedings to Issues::CloseService'
do
...
...
@@ -81,7 +81,7 @@ describe Boards::Issues::MoveService, services: true do
described_class
.
new
(
project
,
user
,
params
).
execute
end
it
'remove
the label of the list it came from
and close the issue'
do
it
'remove
s all list-labels
and close the issue'
do
described_class
.
new
(
project
,
user
,
params
).
execute
issue
.
reload
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录