From bfda3acd715d34a8ddf4d5ceced65fe5320dcf35 Mon Sep 17 00:00:00 2001 From: Rachel Pipkin Date: Mon, 16 Oct 2017 17:53:12 +0000 Subject: [PATCH] Remove extra border radius when editing a file --- app/assets/stylesheets/framework/files.scss | 4 ++++ app/assets/stylesheets/framework/variables.scss | 1 + app/assets/stylesheets/pages/editor.scss | 2 +- app/views/projects/blob/_editor.html.haml | 2 +- .../37978-extra-border-radius-while-editing-a-file.yml | 6 ++++++ 5 files changed, 13 insertions(+), 2 deletions(-) create mode 100644 changelogs/unreleased/37978-extra-border-radius-while-editing-a-file.yml diff --git a/app/assets/stylesheets/framework/files.scss b/app/assets/stylesheets/framework/files.scss index 588ec1ff3bc..5833ef939e9 100644 --- a/app/assets/stylesheets/framework/files.scss +++ b/app/assets/stylesheets/framework/files.scss @@ -10,6 +10,10 @@ border: 0; } + &.file-holder-bottom-radius { + border-radius: 0 0 $border-radius-small $border-radius-small; + } + &.readme-holder { margin: $gl-padding 0; diff --git a/app/assets/stylesheets/framework/variables.scss b/app/assets/stylesheets/framework/variables.scss index 089a67a7c98..d5ca23ff870 100644 --- a/app/assets/stylesheets/framework/variables.scss +++ b/app/assets/stylesheets/framework/variables.scss @@ -233,6 +233,7 @@ $container-text-max-width: 540px; $gl-avatar-size: 40px; $error-exclamation-point: $red-500; $border-radius-default: 4px; +$border-radius-small: 2px; $settings-icon-size: 18px; $provider-btn-not-active-color: $blue-500; $link-underline-blue: $blue-500; diff --git a/app/assets/stylesheets/pages/editor.scss b/app/assets/stylesheets/pages/editor.scss index d3cd4d507de..edfafa79c44 100644 --- a/app/assets/stylesheets/pages/editor.scss +++ b/app/assets/stylesheets/pages/editor.scss @@ -4,7 +4,7 @@ border-right: 1px solid $border-color; border-left: 1px solid $border-color; border-bottom: none; - border-radius: 2px; + border-radius: $border-radius-small $border-radius-small 0 0; background: $gray-normal; } diff --git a/app/views/projects/blob/_editor.html.haml b/app/views/projects/blob/_editor.html.haml index 4b344b2edb9..7777f55ddd7 100644 --- a/app/views/projects/blob/_editor.html.haml +++ b/app/views/projects/blob/_editor.html.haml @@ -1,6 +1,6 @@ - action = current_action?(:edit) || current_action?(:update) ? 'edit' : 'create' -.file-holder.file.append-bottom-default +.file-holder-bottom-radius.file-holder.file.append-bottom-default .js-file-title.file-title.clearfix{ data: { current_action: action } } .editor-ref = icon('code-fork') diff --git a/changelogs/unreleased/37978-extra-border-radius-while-editing-a-file.yml b/changelogs/unreleased/37978-extra-border-radius-while-editing-a-file.yml new file mode 100644 index 00000000000..554249a3f88 --- /dev/null +++ b/changelogs/unreleased/37978-extra-border-radius-while-editing-a-file.yml @@ -0,0 +1,6 @@ +--- +title: Removed extra border radius from .file-editor and .file-holder when editing + a file +merge_request: 14803 +author: Rachel Pipkin +type: fixed -- GitLab