Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
李少辉-开发者
gitlab-foss
提交
b78a69b0
G
gitlab-foss
项目概览
李少辉-开发者
/
gitlab-foss
通知
15
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
G
gitlab-foss
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
未验证
提交
b78a69b0
编写于
7月 31, 2018
作者:
A
Andreas Brandl
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Trigger iid logic from GitHub importer for issues.
上级
a2d647b1
变更
2
显示空白变更内容
内联
并排
Showing
2 changed file
with
27 addition
and
1 deletion
+27
-1
lib/gitlab/github_import/importer/issue_importer.rb
lib/gitlab/github_import/importer/issue_importer.rb
+5
-1
spec/lib/gitlab/github_import/importer/issue_importer_spec.rb
.../lib/gitlab/github_import/importer/issue_importer_spec.rb
+22
-0
未找到文件。
lib/gitlab/github_import/importer/issue_importer.rb
浏览文件 @
b78a69b0
...
...
@@ -55,7 +55,11 @@ module Gitlab
updated_at:
issue
.
updated_at
}
GithubImport
.
insert_and_return_id
(
attributes
,
project
.
issues
)
GithubImport
.
insert_and_return_id
(
attributes
,
project
.
issues
).
tap
do
|
id
|
# We use .insert_and_return_id which effectively disables all callbacks.
# Trigger iid logic here to make sure we track internal id values consistently.
project
.
issues
.
find
(
id
).
ensure_project_iid!
end
rescue
ActiveRecord
::
InvalidForeignKey
# It's possible the project has been deleted since scheduling this
# job. In this case we'll just skip creating the issue.
...
...
spec/lib/gitlab/github_import/importer/issue_importer_spec.rb
浏览文件 @
b78a69b0
...
...
@@ -78,6 +78,11 @@ describe Gitlab::GithubImport::Importer::IssueImporter, :clean_gitlab_redis_cach
.
to
receive
(
:id_for
)
.
with
(
issue
)
.
and_return
(
milestone
.
id
)
allow
(
importer
.
user_finder
)
.
to
receive
(
:author_id_for
)
.
with
(
issue
)
.
and_return
([
user
.
id
,
true
])
end
context
'when the issue author could be found'
do
...
...
@@ -172,6 +177,23 @@ describe Gitlab::GithubImport::Importer::IssueImporter, :clean_gitlab_redis_cach
expect
(
importer
.
create_issue
).
to
be_a_kind_of
(
Numeric
)
end
it
'triggers internal_id functionality to track greatest iids'
do
allow
(
importer
.
user_finder
)
.
to
receive
(
:author_id_for
)
.
with
(
issue
)
.
and_return
([
user
.
id
,
true
])
issue
=
build_stubbed
(
:issue
,
project:
project
)
allow
(
Gitlab
::
GithubImport
)
.
to
receive
(
:insert_and_return_id
)
.
and_return
(
issue
.
id
)
allow
(
project
.
issues
).
to
receive
(
:find
).
with
(
issue
.
id
).
and_return
(
issue
)
expect
(
issue
).
to
receive
(
:ensure_project_iid!
)
importer
.
create_issue
end
end
describe
'#create_assignees'
do
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录