From b167c5b9503ceb8915422b9cedea5042864fa381 Mon Sep 17 00:00:00 2001 From: Ryan Harris Date: Sun, 8 Jan 2017 22:05:13 -0500 Subject: [PATCH] Make play button on Pipelines page accessible via keyboard --- app/views/projects/ci/pipelines/_pipeline.html.haml | 4 ++-- .../26445-make-icon-buttons-accessible-via-keyboard.yml | 4 ++++ 2 files changed, 6 insertions(+), 2 deletions(-) create mode 100644 changelogs/unreleased/26445-make-icon-buttons-accessible-via-keyboard.yml diff --git a/app/views/projects/ci/pipelines/_pipeline.html.haml b/app/views/projects/ci/pipelines/_pipeline.html.haml index aaf1b428178..e698ef2795f 100644 --- a/app/views/projects/ci/pipelines/_pipeline.html.haml +++ b/app/views/projects/ci/pipelines/_pipeline.html.haml @@ -78,9 +78,9 @@ .btn-group.inline - if actions.any? .btn-group - %a.dropdown-toggle.btn.btn-default.js-pipeline-dropdown-manual-actions{ type: 'button', 'data-toggle' => 'dropdown' } + %button.dropdown-toggle.btn.btn-default.js-pipeline-dropdown-manual-actions{ type: 'button', 'data-toggle' => 'dropdown' } = custom_icon('icon_play') - = icon('caret-down') + = icon('caret-down', 'aria-hidden' => 'true') %ul.dropdown-menu.dropdown-menu-align-right - actions.each do |build| %li diff --git a/changelogs/unreleased/26445-make-icon-buttons-accessible-via-keyboard.yml b/changelogs/unreleased/26445-make-icon-buttons-accessible-via-keyboard.yml new file mode 100644 index 00000000000..b4aef8fe3da --- /dev/null +++ b/changelogs/unreleased/26445-make-icon-buttons-accessible-via-keyboard.yml @@ -0,0 +1,4 @@ +--- +title: Make play button on Pipelines page accessible via keyboard +merge_request: +author: Ryan Harris -- GitLab