From a64b5e3c60ab1fe295a397422750e026c35aae97 Mon Sep 17 00:00:00 2001
From: Robert Speicher <rspeicher@gmail.com>
Date: Sat, 25 Apr 2015 21:26:43 -0400
Subject: [PATCH] Convert UserReferenceFilter#link_to_group to use a guard
 clause

---
 lib/gitlab/markdown/user_reference_filter.rb | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/lib/gitlab/markdown/user_reference_filter.rb b/lib/gitlab/markdown/user_reference_filter.rb
index 9cd5245cbcd..28ec041b1d4 100644
--- a/lib/gitlab/markdown/user_reference_filter.rb
+++ b/lib/gitlab/markdown/user_reference_filter.rb
@@ -80,15 +80,13 @@ module Gitlab
       end
 
       def link_to_group(group, namespace)
-        if user_can_reference_group?(namespace)
-          push_result(:user, *namespace.users)
+        return unless user_can_reference_group?(namespace)
 
-          url = urls.group_url(group, only_path: context[:only_path])
+        push_result(:user, *namespace.users)
 
-          %(<a href="#{url}" class="#{link_class}">@#{group}</a>)
-        else
-          nil
-        end
+        url = urls.group_url(group, only_path: context[:only_path])
+
+        %(<a href="#{url}" class="#{link_class}">@#{group}</a>)
       end
 
       def link_to_user(user, namespace)
-- 
GitLab