diff --git a/lib/gitlab/diff/inline_diff.rb b/lib/gitlab/diff/inline_diff.rb
index e5986fd69e2fc5e4e0f15c77fabc8cfa2278eb4f..b8a61ad6115a7f830525e612ab3057cbe3ca8d2f 100644
--- a/lib/gitlab/diff/inline_diff.rb
+++ b/lib/gitlab/diff/inline_diff.rb
@@ -16,15 +16,12 @@ module Gitlab
old_line = @lines[old_index]
new_line = @lines[new_index]
- suffixless_old_line = old_line[1..-1]
- suffixless_new_line = new_line[1..-1]
-
# Skip inline diff if empty line was replaced with content
- next if suffixless_old_line == ""
+ next if old_line[1..-1] == ""
- # Add one, because this is based on the suffixless version
- lcp = longest_common_prefix(suffixless_old_line, suffixless_new_line) + 1
- lcs = longest_common_suffix(suffixless_old_line, suffixless_new_line)
+ # Add one, because this is based on the prefixless version
+ lcp = longest_common_prefix(old_line[1..-1], new_line[1..-1]) + 1
+ lcs = longest_common_suffix(old_line[lcp..-1], new_line[lcp..-1])
old_diff_range = lcp..(old_line.length - lcs - 1)
new_diff_range = lcp..(new_line.length - lcs - 1)
diff --git a/lib/gitlab/diff/inline_diff_marker.rb b/lib/gitlab/diff/inline_diff_marker.rb
index 8998ccba5ce87a3c4dce72105c6ef24b6349933d..c31149d374e29193c6a3457511140d81faada6ed 100644
--- a/lib/gitlab/diff/inline_diff_marker.rb
+++ b/lib/gitlab/diff/inline_diff_marker.rb
@@ -12,7 +12,7 @@ module Gitlab
offset = 0
line_inline_diffs.each do |inline_diff_range|
# Map the inline-diff range based on the raw line to character positions in the rich line
- inline_diff_positions = position_mapping[inline_diff_range]
+ inline_diff_positions = position_mapping[inline_diff_range].flatten
# Turn the array of character positions into ranges
marker_ranges = collapse_ranges(inline_diff_positions)
@@ -47,7 +47,19 @@ module Gitlab
rich_char = rich_line[rich_pos]
end
- mapping[raw_pos] = rich_pos
+ # multi-char HTML entities in the rich line correspond to a single character in the raw line
+ if rich_char == '&'
+ multichar_mapping = [rich_pos]
+ until rich_char == ';'
+ rich_pos += 1
+ multichar_mapping << rich_pos
+ rich_char = rich_line[rich_pos]
+ end
+
+ mapping[raw_pos] = multichar_mapping
+ else
+ mapping[raw_pos] = rich_pos
+ end
rich_pos += 1
end
diff --git a/lib/gitlab/diff/parser.rb b/lib/gitlab/diff/parser.rb
index 2c0a866e8bae1588273608920c25086528d0c3ea..6c8a1fc6d6fbe15fa0e008279507503a43c4108b 100644
--- a/lib/gitlab/diff/parser.rb
+++ b/lib/gitlab/diff/parser.rb
@@ -14,7 +14,7 @@ module Gitlab
@lines.each do |line|
next if filename?(line)
- full_line = html_escape(line.gsub(/\n/, ''))
+ full_line = line.gsub(/\n/, '')
if line.match(/^@@ -/)
type = "match"
@@ -67,11 +67,6 @@ module Gitlab
nil
end
end
-
- def html_escape(str)
- replacements = { '&' => '&', '>' => '>', '<' => '<', '"' => '"', "'" => ''' }
- str.gsub(/[&"'><]/, replacements)
- end
end
end
end
diff --git a/spec/lib/gitlab/diff/inline_diff_marker_spec.rb b/spec/lib/gitlab/diff/inline_diff_marker_spec.rb
index 5d6aea17509485908ebf58fa09e0d52693bb26c7..6f3276a8b533364b367ae2e709c63b52c144d7dc 100644
--- a/spec/lib/gitlab/diff/inline_diff_marker_spec.rb
+++ b/spec/lib/gitlab/diff/inline_diff_marker_spec.rb
@@ -2,14 +2,14 @@ require 'spec_helper'
describe Gitlab::Diff::InlineDiffMarker, lib: true do
describe '#inline_diffs' do
- let(:raw) { "abc def" }
- let(:rich) { %{abc def} }
- let(:inline_diffs) { [2..4] }
+ let(:raw) { "abc 'def'" }
+ let(:rich) { %{abc 'def'} }
+ let(:inline_diffs) { [2..5] }
let(:subject) { Gitlab::Diff::InlineDiffMarker.new(raw, rich).mark(inline_diffs) }
it 'marks the inline diffs' do
- expect(subject).to eq(%{abc def})
+ expect(subject).to eq(%{abc 'def'})
end
end
end
diff --git a/spec/lib/gitlab/diff/parser_spec.rb b/spec/lib/gitlab/diff/parser_spec.rb
index ba577bd28e5fa4bb1d0381376bc0a46a55341b3e..fe0dea77909ae6c3ed97c956e7010905fdfd2ceb 100644
--- a/spec/lib/gitlab/diff/parser_spec.rb
+++ b/spec/lib/gitlab/diff/parser_spec.rb
@@ -86,7 +86,7 @@ eos
it { expect(line.type).to eq(nil) }
it { expect(line.old_pos).to eq(24) }
it { expect(line.new_pos).to eq(31) }
- it { expect(line.text).to eq(' @cmd_output << stderr.read') }
+ it { expect(line.text).to eq(' @cmd_output << stderr.read') }
end
end
end