From 9d307ee0260caac256eac88da0f6910035f41597 Mon Sep 17 00:00:00 2001 From: Phil Hughes Date: Fri, 5 Aug 2016 14:40:12 +0100 Subject: [PATCH] Fixed issue with cookie working across whole site --- app/assets/javascripts/boards/components/board.js.es6 | 5 +---- app/assets/javascripts/boards/components/board_list.js.es6 | 5 +---- app/assets/javascripts/boards/stores/boards_store.js.es6 | 1 - 3 files changed, 2 insertions(+), 9 deletions(-) diff --git a/app/assets/javascripts/boards/components/board.js.es6 b/app/assets/javascripts/boards/components/board.js.es6 index 67b630d7750..755469744d7 100644 --- a/app/assets/javascripts/boards/components/board.js.es6 +++ b/app/assets/javascripts/boards/components/board.js.es6 @@ -27,7 +27,7 @@ } }, ready: function () { - this.sortable = Sortable.create(this.$el.parentNode, { + Sortable.create(this.$el.parentNode, { group: 'boards', animation: 150, draggable: '.is-draggable', @@ -38,9 +38,6 @@ BoardsStore.moveList(e.oldIndex, e.newIndex); } }); - }, - beforeDestroy: function () { - this.sortable.destroy(); } }); diff --git a/app/assets/javascripts/boards/components/board_list.js.es6 b/app/assets/javascripts/boards/components/board_list.js.es6 index 7a00f090ade..4b949661d22 100644 --- a/app/assets/javascripts/boards/components/board_list.js.es6 +++ b/app/assets/javascripts/boards/components/board_list.js.es6 @@ -29,7 +29,7 @@ }, }, ready: function () { - this.sortable = Sortable.create(this.$els.list, { + Sortable.create(this.$els.list, { sort: false, group: 'issues', disabled: this.disabled, @@ -55,9 +55,6 @@ this.loadFromLastId(); } }; - }, - beforeDestroy: function () { - this.sortable.destroy(); } }); diff --git a/app/assets/javascripts/boards/stores/boards_store.js.es6 b/app/assets/javascripts/boards/stores/boards_store.js.es6 index b1edd8d2480..64e85cebb65 100644 --- a/app/assets/javascripts/boards/stores/boards_store.js.es6 +++ b/app/assets/javascripts/boards/stores/boards_store.js.es6 @@ -63,7 +63,6 @@ this.removeList('blank'); $.cookie('issue_board_welcome_hidden', 'true', { - path: '/', expires: 365 * 10 }); }, -- GitLab