From 9d06504d4277ecf53e6f19014d060c6e7009dc0d Mon Sep 17 00:00:00 2001 From: Winnie Hellmann Date: Wed, 28 Feb 2018 21:23:58 +0000 Subject: [PATCH] Forbid all inline script tags in Linter::InlineJavaScript --- lib/haml_lint/inline_javascript.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/haml_lint/inline_javascript.rb b/lib/haml_lint/inline_javascript.rb index f5485eb89fa..872502bc8e3 100644 --- a/lib/haml_lint/inline_javascript.rb +++ b/lib/haml_lint/inline_javascript.rb @@ -8,7 +8,7 @@ unless Rails.env.production? include LinterRegistry def visit_filter(node) - return unless node.filter_type == 'javascript' + return unless node.tag_name == 'script' record_lint(node, 'Inline JavaScript is discouraged (https://docs.gitlab.com/ee/development/gotchas.html#do-not-use-inline-javascript-in-views)') end -- GitLab