From 9bf293a22199c810ca118a1a324528ce8357af97 Mon Sep 17 00:00:00 2001 From: Clement Ho Date: Thu, 17 May 2018 18:23:54 -0400 Subject: [PATCH] Fix variable list karma specs --- .../behaviors/secret_values_spec.js | 36 +++++++++---------- .../ajax_variable_list_spec.js | 2 +- .../ci_variable_list/ci_variable_list_spec.js | 2 +- 3 files changed, 20 insertions(+), 20 deletions(-) diff --git a/spec/javascripts/behaviors/secret_values_spec.js b/spec/javascripts/behaviors/secret_values_spec.js index 63d44b03b23..95122fcf30f 100644 --- a/spec/javascripts/behaviors/secret_values_spec.js +++ b/spec/javascripts/behaviors/secret_values_spec.js @@ -77,9 +77,9 @@ describe('setupSecretValues', () => { const placeholders = wrapper.querySelectorAll('.js-secret-value-placeholder'); expect(values.length).toEqual(1); - expect(values[0].classList.contains('hidden')).toEqual(true); + expect(values[0].classList.contains('hide')).toEqual(true); expect(placeholders.length).toEqual(1); - expect(placeholders[0].classList.contains('hidden')).toEqual(false); + expect(placeholders[0].classList.contains('hide')).toEqual(false); }); it('should toggle value and placeholder', () => { @@ -91,16 +91,16 @@ describe('setupSecretValues', () => { revealButton.click(); expect(values.length).toEqual(1); - expect(values[0].classList.contains('hidden')).toEqual(false); + expect(values[0].classList.contains('hide')).toEqual(false); expect(placeholders.length).toEqual(1); - expect(placeholders[0].classList.contains('hidden')).toEqual(true); + expect(placeholders[0].classList.contains('hide')).toEqual(true); revealButton.click(); expect(values.length).toEqual(1); - expect(values[0].classList.contains('hidden')).toEqual(true); + expect(values[0].classList.contains('hide')).toEqual(true); expect(placeholders.length).toEqual(1); - expect(placeholders[0].classList.contains('hidden')).toEqual(false); + expect(placeholders[0].classList.contains('hide')).toEqual(false); }); }); @@ -128,11 +128,11 @@ describe('setupSecretValues', () => { expect(values.length).toEqual(3); values.forEach((value) => { - expect(value.classList.contains('hidden')).toEqual(true); + expect(value.classList.contains('hide')).toEqual(true); }); expect(placeholders.length).toEqual(3); placeholders.forEach((placeholder) => { - expect(placeholder.classList.contains('hidden')).toEqual(false); + expect(placeholder.classList.contains('hide')).toEqual(false); }); }); @@ -146,22 +146,22 @@ describe('setupSecretValues', () => { expect(values.length).toEqual(3); values.forEach((value) => { - expect(value.classList.contains('hidden')).toEqual(false); + expect(value.classList.contains('hide')).toEqual(false); }); expect(placeholders.length).toEqual(3); placeholders.forEach((placeholder) => { - expect(placeholder.classList.contains('hidden')).toEqual(true); + expect(placeholder.classList.contains('hide')).toEqual(true); }); revealButton.click(); expect(values.length).toEqual(3); values.forEach((value) => { - expect(value.classList.contains('hidden')).toEqual(true); + expect(value.classList.contains('hide')).toEqual(true); }); expect(placeholders.length).toEqual(3); placeholders.forEach((placeholder) => { - expect(placeholder.classList.contains('hidden')).toEqual(false); + expect(placeholder.classList.contains('hide')).toEqual(false); }); }); }); @@ -182,22 +182,22 @@ describe('setupSecretValues', () => { expect(values.length).toEqual(4); values.forEach((value) => { - expect(value.classList.contains('hidden')).toEqual(false); + expect(value.classList.contains('hide')).toEqual(false); }); expect(placeholders.length).toEqual(4); placeholders.forEach((placeholder) => { - expect(placeholder.classList.contains('hidden')).toEqual(true); + expect(placeholder.classList.contains('hide')).toEqual(true); }); revealButton.click(); expect(values.length).toEqual(4); values.forEach((value) => { - expect(value.classList.contains('hidden')).toEqual(true); + expect(value.classList.contains('hide')).toEqual(true); }); expect(placeholders.length).toEqual(4); placeholders.forEach((placeholder) => { - expect(placeholder.classList.contains('hidden')).toEqual(false); + expect(placeholder.classList.contains('hide')).toEqual(false); }); }); }); @@ -220,9 +220,9 @@ describe('setupSecretValues', () => { revealButton.click(); expect(values.length).toEqual(1); - expect(values[0].classList.contains('hidden')).toEqual(false); + expect(values[0].classList.contains('hide')).toEqual(false); expect(placeholders.length).toEqual(1); - expect(placeholders[0].classList.contains('hidden')).toEqual(true); + expect(placeholders[0].classList.contains('hide')).toEqual(true); }); }); }); diff --git a/spec/javascripts/ci_variable_list/ajax_variable_list_spec.js b/spec/javascripts/ci_variable_list/ajax_variable_list_spec.js index 09014ad733b..ee457a9c48c 100644 --- a/spec/javascripts/ci_variable_list/ajax_variable_list_spec.js +++ b/spec/javascripts/ci_variable_list/ajax_variable_list_spec.js @@ -4,7 +4,7 @@ import axios from '~/lib/utils/axios_utils'; import AjaxFormVariableList from '~/ci_variable_list/ajax_variable_list'; const VARIABLE_PATCH_ENDPOINT = 'http://test.host/frontend-fixtures/builds-project/variables'; -const HIDE_CLASS = 'hidden'; +const HIDE_CLASS = 'hide'; describe('AjaxFormVariableList', () => { preloadFixtures('projects/ci_cd_settings.html.raw'); diff --git a/spec/javascripts/ci_variable_list/ci_variable_list_spec.js b/spec/javascripts/ci_variable_list/ci_variable_list_spec.js index 6e1dedd2dad..2fa50975f0f 100644 --- a/spec/javascripts/ci_variable_list/ci_variable_list_spec.js +++ b/spec/javascripts/ci_variable_list/ci_variable_list_spec.js @@ -2,7 +2,7 @@ import $ from 'jquery'; import VariableList from '~/ci_variable_list/ci_variable_list'; import getSetTimeoutPromise from 'spec/helpers/set_timeout_promise_helper'; -const HIDE_CLASS = 'hidden'; +const HIDE_CLASS = 'hide'; describe('VariableList', () => { preloadFixtures('pipeline_schedules/edit.html.raw'); -- GitLab