From 90778e5d2752d4c10a536127d6ce75c32951b8c6 Mon Sep 17 00:00:00 2001 From: Andreas Brandl Date: Fri, 27 Jul 2018 14:39:48 +0200 Subject: [PATCH] Require has_internal_id to pass a init block. This is useful since the current scheme allows us to freely delete any records in internal_ids. If the record is not there, it will get rebuild using the init block. We require passing in 'init for the time being and as long as its not expensive to do so. This makes the scheme a bit more robust. If at some point, this is expensive - we may choose to make this optional while losing the ability to recalculate the value on the fly. Closes #49609. --- app/models/concerns/atomic_internal_id.rb | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/app/models/concerns/atomic_internal_id.rb b/app/models/concerns/atomic_internal_id.rb index 164c704260e..4fef615e6e3 100644 --- a/app/models/concerns/atomic_internal_id.rb +++ b/app/models/concerns/atomic_internal_id.rb @@ -26,6 +26,10 @@ module AtomicInternalId module ClassMethods def has_internal_id(column, scope:, init:, presence: true) # rubocop:disable Naming/PredicateName + # We require init here to retain the ability to recalculate in the absence of a + # InternaLId record (we may delete records in `internal_ids` for example). + raise "has_internal_id requires a init block, none given." unless init + before_validation :"ensure_#{scope}_#{column}!", on: :create validates column, presence: presence -- GitLab