Merge branch 'frozen-string-app-workers' into 'master'

Enable frozen string literals for app/workers/*.rb

See merge request gitlab-org/gitlab-ce!19944

app/workers/admin_email_worker.rb

+# frozen_string_literal: true
+
 class AdminEmailWorker
   include ApplicationWorker
   include CronjobQueue

app/workers/archive_trace_worker.rb

+# frozen_string_literal: true
+
 class ArchiveTraceWorker
   include ApplicationWorker
   include PipelineBackgroundQueue

app/workers/authorized_projects_worker.rb

+# frozen_string_literal: true
+
 class AuthorizedProjectsWorker
   include ApplicationWorker
   prepend WaitableWorker

app/workers/background_migration_worker.rb

+# frozen_string_literal: true
+
 class BackgroundMigrationWorker
   include ApplicationWorker
 

app/workers/build_coverage_worker.rb

+# frozen_string_literal: true
+
 class BuildCoverageWorker
   include ApplicationWorker
   include PipelineQueue

app/workers/build_finished_worker.rb

+# frozen_string_literal: true
+
 class BuildFinishedWorker
   include ApplicationWorker
   include PipelineQueue

app/workers/build_hooks_worker.rb

+# frozen_string_literal: true
+
 class BuildHooksWorker
   include ApplicationWorker
   include PipelineQueue

app/workers/build_queue_worker.rb

+# frozen_string_literal: true
+
 class BuildQueueWorker
   include ApplicationWorker
   include PipelineQueue

app/workers/build_success_worker.rb

+# frozen_string_literal: true
+
 class BuildSuccessWorker
   include ApplicationWorker
   include PipelineQueue

app/workers/build_trace_sections_worker.rb

+# frozen_string_literal: true
+
 class BuildTraceSectionsWorker
   include ApplicationWorker
   include PipelineQueue

app/workers/cluster_install_app_worker.rb

+# frozen_string_literal: true
+
 class ClusterInstallAppWorker
   include ApplicationWorker
   include ClusterQueue

app/workers/cluster_provision_worker.rb

+# frozen_string_literal: true
+
 class ClusterProvisionWorker
   include ApplicationWorker
   include ClusterQueue

app/workers/cluster_wait_for_app_installation_worker.rb

+# frozen_string_literal: true
+
 class ClusterWaitForAppInstallationWorker
   include ApplicationWorker
   include ClusterQueue

app/workers/cluster_wait_for_ingress_ip_address_worker.rb

+# frozen_string_literal: true
+
 class ClusterWaitForIngressIpAddressWorker
   include ApplicationWorker
   include ClusterQueue

app/workers/create_gpg_signature_worker.rb

+# frozen_string_literal: true
+
 class CreateGpgSignatureWorker
   include ApplicationWorker
 

app/workers/create_note_diff_file_worker.rb

+# frozen_string_literal: true
+
 class CreateNoteDiffFileWorker
   include ApplicationWorker
 

app/workers/create_pipeline_worker.rb

+# frozen_string_literal: true
+
 class CreatePipelineWorker
   include ApplicationWorker
   include PipelineQueue

app/workers/delete_merged_branches_worker.rb

+# frozen_string_literal: true
+
 class DeleteMergedBranchesWorker
   include ApplicationWorker
 

app/workers/delete_user_worker.rb

+# frozen_string_literal: true
+
 class DeleteUserWorker
   include ApplicationWorker
 

app/workers/email_receiver_worker.rb

+# frozen_string_literal: true
+
 class EmailReceiverWorker
   include ApplicationWorker
 

app/workers/emails_on_push_worker.rb

+# frozen_string_literal: true
+
 class EmailsOnPushWorker
   include ApplicationWorker
 

app/workers/expire_build_artifacts_worker.rb

+# frozen_string_literal: true
+
 class ExpireBuildArtifactsWorker
   include ApplicationWorker
   include CronjobQueue

app/workers/expire_build_instance_artifacts_worker.rb

+# frozen_string_literal: true
+
 class ExpireBuildInstanceArtifactsWorker
   include ApplicationWorker
 

app/workers/expire_job_cache_worker.rb

+# frozen_string_literal: true
+
 class ExpireJobCacheWorker
   include ApplicationWorker
   include PipelineQueue

app/workers/expire_pipeline_cache_worker.rb

+# frozen_string_literal: true
+
 class ExpirePipelineCacheWorker
   include ApplicationWorker
   include PipelineQueue

app/workers/git_garbage_collect_worker.rb

+# frozen_string_literal: true
+
 class GitGarbageCollectWorker
   include ApplicationWorker
 

app/workers/gitlab_shell_worker.rb

+# frozen_string_literal: true
+
 class GitlabShellWorker
   include ApplicationWorker
   include Gitlab::ShellAdapter

app/workers/gitlab_usage_ping_worker.rb

+# frozen_string_literal: true
+
 class GitlabUsagePingWorker
   LEASE_TIMEOUT = 86400
 

app/workers/group_destroy_worker.rb

+# frozen_string_literal: true
+
 class GroupDestroyWorker
   include ApplicationWorker
   include ExceptionBacktrace

app/workers/import_export_project_cleanup_worker.rb

+# frozen_string_literal: true
+
 class ImportExportProjectCleanupWorker
   include ApplicationWorker
   include CronjobQueue

app/workers/invalid_gpg_signature_update_worker.rb

+# frozen_string_literal: true
+
 class InvalidGpgSignatureUpdateWorker
   include ApplicationWorker
 

app/workers/irker_worker.rb

+# frozen_string_literal: true
+
 require 'json'
 require 'socket'
 
@@ -69,8 +71,8 @@ class IrkerWorker
     newbranch = "#{Gitlab.config.gitlab.url}/#{repo_path}/branches"
     newbranch = "\x0302\x1f#{newbranch}\x0f" if @colors
 
-    privmsg = "[#{repo_name}] #{committer} has created a new branch "
-    privmsg += "#{branch}: #{newbranch}"
+    privmsg = "[#{repo_name}] #{committer} has created a new branch " \
+              "#{branch}: #{newbranch}"
     sendtoirker privmsg
   end
 
@@ -112,9 +114,7 @@ class IrkerWorker
     url = compare_url data, project.full_path
     commits = colorize_commits data['total_commits_count']
 
-    new_commits = 'new commit'
-    new_commits += 's' if data['total_commits_count'] > 1
-
+    new_commits = 'new commit'.pluralize(data['total_commits_count'])
     sendtoirker "[#{repo}] #{committer} pushed #{commits} #{new_commits} " \
                 "to #{branch}: #{url}"
   end
@@ -122,8 +122,8 @@ class IrkerWorker
   def compare_url(data, repo_path)
     sha1 = Commit.truncate_sha(data['before'])
     sha2 = Commit.truncate_sha(data['after'])
-    compare_url = "#{Gitlab.config.gitlab.url}/#{repo_path}/compare"
-    compare_url += "/#{sha1}...#{sha2}"
+    compare_url = "#{Gitlab.config.gitlab.url}/#{repo_path}/compare" \
+                  "/#{sha1}...#{sha2}"
     colorize_url compare_url
   end
 
@@ -144,8 +144,7 @@ class IrkerWorker
   def files_count(commit)
     diff_size = commit.raw_deltas.size
 
-    files = "#{diff_size} file"
-    files += 's' if diff_size > 1
+    files = "#{diff_size} file".pluralize(diff_size)
     files
   end
 

app/workers/issue_due_scheduler_worker.rb

+# frozen_string_literal: true
+
 class IssueDueSchedulerWorker
   include ApplicationWorker
   include CronjobQueue

app/workers/merge_worker.rb

+# frozen_string_literal: true
+
 class MergeWorker
   include ApplicationWorker
 

app/workers/namespaceless_project_destroy_worker.rb

+# frozen_string_literal: true
+
 # Worker to destroy projects that do not have a namespace
 #
 # It destroys everything it can without having the info about the namespace it

app/workers/new_issue_worker.rb

+# frozen_string_literal: true
+
 class NewIssueWorker
   include ApplicationWorker
   include NewIssuable

app/workers/new_merge_request_worker.rb

+# frozen_string_literal: true
+
 class NewMergeRequestWorker
   include ApplicationWorker
   include NewIssuable

app/workers/new_note_worker.rb

+# frozen_string_literal: true
+
 class NewNoteWorker
   include ApplicationWorker
 

app/workers/object_storage_upload_worker.rb

+# frozen_string_literal: true
+
 # @Deprecated - remove once the `object_storage_upload` queue is empty
 # The queue has been renamed `object_storage:object_storage_background_upload`
 #

app/workers/pages_domain_verification_cron_worker.rb

+# frozen_string_literal: true
+
 class PagesDomainVerificationCronWorker
   include ApplicationWorker
   include CronjobQueue

app/workers/pages_domain_verification_worker.rb

+# frozen_string_literal: true
+
 class PagesDomainVerificationWorker
   include ApplicationWorker
 

app/workers/pages_worker.rb

+# frozen_string_literal: true
+
 class PagesWorker
   include ApplicationWorker
 

app/workers/pipeline_hooks_worker.rb

+# frozen_string_literal: true
+
 class PipelineHooksWorker
   include ApplicationWorker
   include PipelineQueue

app/workers/pipeline_metrics_worker.rb

+# frozen_string_literal: true
+
 class PipelineMetricsWorker
   include ApplicationWorker
   include PipelineQueue

app/workers/pipeline_notification_worker.rb

+# frozen_string_literal: true
+
 class PipelineNotificationWorker
   include ApplicationWorker
   include PipelineQueue

app/workers/pipeline_process_worker.rb

+# frozen_string_literal: true
+
 class PipelineProcessWorker
   include ApplicationWorker
   include PipelineQueue

app/workers/pipeline_schedule_worker.rb

+# frozen_string_literal: true
+
 class PipelineScheduleWorker
   include ApplicationWorker
   include CronjobQueue

app/workers/pipeline_success_worker.rb

+# frozen_string_literal: true
+
 class PipelineSuccessWorker
   include ApplicationWorker
   include PipelineQueue

app/workers/pipeline_update_worker.rb

+# frozen_string_literal: true
+
 class PipelineUpdateWorker
   include ApplicationWorker
   include PipelineQueue

app/workers/plugin_worker.rb

+# frozen_string_literal: true
+
 class PluginWorker
   include ApplicationWorker
 

app/workers/post_receive.rb

+# frozen_string_literal: true
+
 class PostReceive
   include ApplicationWorker
 

app/workers/process_commit_worker.rb

+# frozen_string_literal: true
+
 # Worker for processing individiual commit messages pushed to a repository.
 #
 # Jobs for this worker are scheduled for every commit that is being pushed. As a

app/workers/project_cache_worker.rb

+# frozen_string_literal: true
+
 # Worker for updating any project specific caches.
 class ProjectCacheWorker
   include ApplicationWorker

app/workers/project_destroy_worker.rb

+# frozen_string_literal: true
+
 class ProjectDestroyWorker
   include ApplicationWorker
   include ExceptionBacktrace

app/workers/project_export_worker.rb

+# frozen_string_literal: true
+
 class ProjectExportWorker
   include ApplicationWorker
   include ExceptionBacktrace

app/workers/project_migrate_hashed_storage_worker.rb

+# frozen_string_literal: true
+
 class ProjectMigrateHashedStorageWorker
   include ApplicationWorker
 

app/workers/project_service_worker.rb

+# frozen_string_literal: true
+
 class ProjectServiceWorker
   include ApplicationWorker
 

app/workers/propagate_service_template_worker.rb

+# frozen_string_literal: true
+
 # Worker for updating any project specific caches.
 class PropagateServiceTemplateWorker
   include ApplicationWorker

app/workers/prune_old_events_worker.rb

+# frozen_string_literal: true
+
 class PruneOldEventsWorker
   include ApplicationWorker
   include CronjobQueue

app/workers/reactive_caching_worker.rb

+# frozen_string_literal: true
+
 class ReactiveCachingWorker
   include ApplicationWorker
 

app/workers/rebase_worker.rb

+# frozen_string_literal: true
+
 class RebaseWorker
   include ApplicationWorker
 

app/workers/remove_expired_group_links_worker.rb

+# frozen_string_literal: true
+
 class RemoveExpiredGroupLinksWorker
   include ApplicationWorker
   include CronjobQueue

app/workers/remove_expired_members_worker.rb

+# frozen_string_literal: true
+
 class RemoveExpiredMembersWorker
   include ApplicationWorker
   include CronjobQueue

app/workers/remove_old_web_hook_logs_worker.rb

+# frozen_string_literal: true
+
 class RemoveOldWebHookLogsWorker
   include ApplicationWorker
   include CronjobQueue

app/workers/remove_unreferenced_lfs_objects_worker.rb

+# frozen_string_literal: true
+
 class RemoveUnreferencedLfsObjectsWorker
   include ApplicationWorker
   include CronjobQueue

app/workers/repository_archive_cache_worker.rb

+# frozen_string_literal: true
+
 class RepositoryArchiveCacheWorker
   include ApplicationWorker
   include CronjobQueue

app/workers/repository_fork_worker.rb

+# frozen_string_literal: true
+
 class RepositoryForkWorker
   include ApplicationWorker
   include Gitlab::ShellAdapter

app/workers/repository_import_worker.rb

+# frozen_string_literal: true
+
 class RepositoryImportWorker
   include ApplicationWorker
   include ExceptionBacktrace

app/workers/repository_remove_remote_worker.rb

+# frozen_string_literal: true
+
 class RepositoryRemoveRemoteWorker
   include ApplicationWorker
   include ExclusiveLeaseGuard

app/workers/repository_update_remote_mirror_worker.rb

+# frozen_string_literal: true
+
 class RepositoryUpdateRemoteMirrorWorker
   UpdateAlreadyInProgressError = Class.new(StandardError)
   UpdateError = Class.new(StandardError)

app/workers/requests_profiles_worker.rb

+# frozen_string_literal: true
+
 class RequestsProfilesWorker
   include ApplicationWorker
   include CronjobQueue

app/workers/run_pipeline_schedule_worker.rb

+# frozen_string_literal: true
+
 class RunPipelineScheduleWorker
   include ApplicationWorker
   include PipelineQueue

app/workers/schedule_update_user_activity_worker.rb

+# frozen_string_literal: true
+
 class ScheduleUpdateUserActivityWorker
   include ApplicationWorker
   include CronjobQueue

app/workers/stage_update_worker.rb

+# frozen_string_literal: true
+
 class StageUpdateWorker
   include ApplicationWorker
   include PipelineQueue

app/workers/storage_migrator_worker.rb

+# frozen_string_literal: true
+
 class StorageMigratorWorker
   include ApplicationWorker
 

app/workers/stuck_ci_jobs_worker.rb

+# frozen_string_literal: true
+
 class StuckCiJobsWorker
   include ApplicationWorker
   include CronjobQueue

app/workers/stuck_import_jobs_worker.rb

+# frozen_string_literal: true
+
 class StuckImportJobsWorker
   include ApplicationWorker
   include CronjobQueue

app/workers/stuck_merge_jobs_worker.rb

+# frozen_string_literal: true
+
 class StuckMergeJobsWorker
   include ApplicationWorker
   include CronjobQueue

app/workers/system_hook_push_worker.rb

+# frozen_string_literal: true
+
 class SystemHookPushWorker
   include ApplicationWorker
 

app/workers/trending_projects_worker.rb

+# frozen_string_literal: true
+
 class TrendingProjectsWorker
   include ApplicationWorker
   include CronjobQueue

app/workers/update_head_pipeline_for_merge_request_worker.rb

+# frozen_string_literal: true
+
 class UpdateHeadPipelineForMergeRequestWorker
   include ApplicationWorker
   include PipelineQueue

app/workers/update_merge_requests_worker.rb

+# frozen_string_literal: true
+
 class UpdateMergeRequestsWorker
   include ApplicationWorker
 

app/workers/update_user_activity_worker.rb

+# frozen_string_literal: true
+
 class UpdateUserActivityWorker
   include ApplicationWorker
 

app/workers/upload_checksum_worker.rb

+# frozen_string_literal: true
+
 class UploadChecksumWorker
   include ApplicationWorker
 

app/workers/wait_for_cluster_creation_worker.rb

+# frozen_string_literal: true
+
 class WaitForClusterCreationWorker
   include ApplicationWorker
   include ClusterQueue

app/workers/web_hook_worker.rb

+# frozen_string_literal: true
+
 class WebHookWorker
   include ApplicationWorker
 

changelogs/unreleased/frozen-string-app-workers.yml

+---
+title: Enable frozen string in app/workers/*.rb
+merge_request: 19944
+author: gfyoung
+type: other