From 7b382af73956518b73872c9638754e86da15d915 Mon Sep 17 00:00:00 2001
From: Clement Ho <ClemMakesApps@gmail.com>
Date: Tue, 8 Nov 2016 14:18:46 -0600
Subject: [PATCH] Add support for quotations

---
 .../filtered_search_manager.js.es6            | 41 ++++++++++++++++---
 1 file changed, 36 insertions(+), 5 deletions(-)

diff --git a/app/assets/javascripts/filtered_search/filtered_search_manager.js.es6 b/app/assets/javascripts/filtered_search/filtered_search_manager.js.es6
index 63cdcecdf49..f5e53d075b0 100644
--- a/app/assets/javascripts/filtered_search/filtered_search_manager.js.es6
+++ b/app/assets/javascripts/filtered_search/filtered_search_manager.js.es6
@@ -68,7 +68,13 @@
 
         if (match) {
           const sanitizedKey = key.slice(0, key.indexOf('_'));
-          inputValue += `${sanitizedKey}:${value} `;
+          let sanitizedValue = value;
+
+          if (match && sanitizedKey === 'label') {
+            sanitizedValue = sanitizedValue.replace(/%20/g, ' ');
+          }
+
+          inputValue += `${sanitizedKey}:${sanitizedValue} `;
         } else if (!match && key === 'search') {
           // Sanitize value as URL converts spaces into +
           const sanitizedValue = value.replace(/[+]/g, ' ');
@@ -91,26 +97,51 @@
       // Enable clear button
       document.querySelector('.clear-search').classList.remove('hidden');
 
-      // TODO: Current implementation does not support token values that have valid spaces in them
-      // Example/ label:community contribution
       const input = event.target.value;
       const inputs = input.split(' ');
       let searchTerms = '';
+      let lastQuotation = '';
+      let incompleteToken = false;
 
       const addSearchTerm = function addSearchTerm(term) {
         searchTerms += term + ' ';
       }
 
       inputs.forEach((i) => {
+        if (incompleteToken) {
+          const prevToken = this.tokens[this.tokens.length - 1];
+          prevToken.value += ` ${i}`;
+
+          // Remove last quotation
+          const lastQuotationRegex = new RegExp(lastQuotation, 'g');
+          prevToken.value = prevToken.value.replace(lastQuotationRegex, '');
+          this.tokens[this.tokens.length - 1] = prevToken;
+
+          // Check to see if this quotation completes the token value
+          if (i.indexOf(lastQuotation)) {
+            incompleteToken = !incompleteToken;
+          }
+
+          return;
+        }
+
         const colonIndex = i.indexOf(':');
 
         if (colonIndex !== -1) {
           const tokenKey = i.slice(0, colonIndex).toLowerCase();
           const tokenValue = i.slice(colonIndex + 1);
 
-          const match = validTokenKeys.filter((v) => {
+          const match = validTokenKeys.find((v) => {
             return v.key === tokenKey;
-          })[0];
+          });
+
+          if (tokenValue.indexOf('"') !== -1) {
+            lastQuotation = '"';
+            incompleteToken = true;
+          } else if (tokenValue.indexOf('\'') !== -1) {
+            lastQuotation = '\'';
+            incompleteToken = true;
+          }
 
           if (match && tokenValue.length > 0) {
             this.tokens.push({
-- 
GitLab