From 5af5815d62f3430c52bb489c590eaa32402b18fa Mon Sep 17 00:00:00 2001
From: Shinya Maeda <shinya@gitlab.com>
Date: Fri, 18 May 2018 16:05:11 +0900
Subject: [PATCH] Add the same gurad clause with artifacts uplaoding

---
 lib/api/runner.rb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lib/api/runner.rb b/lib/api/runner.rb
index a4df98cadac..a7f1cb1131f 100644
--- a/lib/api/runner.rb
+++ b/lib/api/runner.rb
@@ -149,6 +149,7 @@ module API
       end
       patch '/:id/trace' do
         job = authenticate_job!
+        forbidden!('Job is not running') unless job.running?
 
         error!('400 Missing header Content-Range', 400) unless request.headers.key?('Content-Range')
         content_range = request.headers['Content-Range']
@@ -165,7 +166,7 @@ module API
         body_start = content_range[0].to_i
         body_end = body_start + body_data.bytesize
 
-        stream_size = job.trace.append(body_data, body_start)  if job.running?
+        stream_size = job.trace.append(body_data, body_start)
         unless stream_size == body_end
           break error!('416 Range Not Satisfiable', 416, { 'Range' => "0-#{stream_size}" })
         end
-- 
GitLab