Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
李少辉-开发者
gitlab-foss
提交
539bdf73
G
gitlab-foss
项目概览
李少辉-开发者
/
gitlab-foss
通知
15
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
G
gitlab-foss
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
539bdf73
编写于
3月 14, 2018
作者:
A
Andreas Brandl
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Address review comments.
上级
d9a953c8
变更
2
显示空白变更内容
内联
并排
Showing
2 changed file
with
15 addition
and
17 deletion
+15
-17
app/models/concerns/atomic_internal_id.rb
app/models/concerns/atomic_internal_id.rb
+12
-15
app/models/internal_id.rb
app/models/internal_id.rb
+3
-2
未找到文件。
app/models/concerns/atomic_internal_id.rb
浏览文件 @
539bdf73
...
...
@@ -24,17 +24,15 @@
module
AtomicInternalId
extend
ActiveSupport
::
Concern
included
do
class
<<
self
module
ClassMethods
def
has_internal_id
(
on
,
scope
:,
usage:
nil
,
init
:)
# rubocop:disable Naming/PredicateName
before_validation
(
on: :create
)
do
if
self
.
public_send
(
on
).
blank?
# rubocop:disable GitlabSecurity/PublicSend
scope_attrs
=
[
scope
].
flatten
.
compact
.
each_with_object
({})
do
|
e
,
h
|
h
[
e
]
=
self
.
public_send
(
e
)
# rubocop:disable GitlabSecurity/PublicSend
end
usage
=
(
usage
||
self
.
class
.
name
.
tableiz
e
).
to_sym
usage
=
(
usage
||
self
.
class
.
table_nam
e
).
to_sym
new_iid
=
InternalId
.
generate_next
(
self
,
scope_attrs
,
usage
,
init
)
self
.
public_send
(
"
#{
on
}
="
,
new_iid
)
# rubocop:disable GitlabSecurity/PublicSend
end
...
...
@@ -43,7 +41,6 @@ module AtomicInternalId
validates
on
,
presence:
true
,
numericality:
true
end
end
end
def
to_param
iid
.
to_s
...
...
app/models/internal_id.rb
浏览文件 @
539bdf73
...
...
@@ -67,16 +67,17 @@ class InternalId < ActiveRecord::Base
# usage: Symbol to define the usage of the internal id, see InternalId.usages
# init: Block that gets called to initialize InternalId record if not present
attr_reader
:subject
,
:scope
,
:init
,
:scope_attrs
,
:usage
def
initialize
(
subject
,
scope
,
usage
,
init
)
@subject
=
subject
@scope
=
scope
@init
=
init
@usage
=
usage
raise
'scope is not well-defined, need at least one column for scope (given: 0)'
if
scope
.
empty?
raise
ArgumentError
,
'scope is not well-defined, need at least one column for scope (given: 0)'
if
scope
.
empty?
unless
InternalId
.
usages
.
keys
.
include?
(
usage
.
to_s
)
raise
"Usage '
#{
usage
}
' is unknown. Supported values are
#{
InternalId
.
usages
.
keys
}
from InternalId.usages"
raise
ArgumentError
,
"Usage '
#{
usage
}
' is unknown. Supported values are
#{
InternalId
.
usages
.
keys
}
from InternalId.usages"
end
end
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录