From 43b6a3eac14a3fb96ed248120c31b41ba8cd6a06 Mon Sep 17 00:00:00 2001 From: Lin Jen-Shin Date: Wed, 20 Jul 2016 00:33:31 +0800 Subject: [PATCH] Check against type explicit, feedback: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5347/diffs#note_13173368 https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5347/diffs#note_13173370 --- spec/models/build_spec.rb | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/spec/models/build_spec.rb b/spec/models/build_spec.rb index 157b11d9130..e4fdfdcf03e 100644 --- a/spec/models/build_spec.rb +++ b/spec/models/build_spec.rb @@ -687,8 +687,9 @@ describe Ci::Build, models: true do end it 'returns empty relation if the build cannot be found' do - builds = project.latest_successful_builds_for('TAIL').all + builds = project.latest_successful_builds_for('TAIL') + expect(builds).to be_kind_of(ActiveRecord::Relation) expect(builds).to be_empty end end @@ -699,8 +700,9 @@ describe Ci::Build, models: true do end it 'returns empty relation' do - builds = project.latest_successful_builds_for('fix').all + builds = project.latest_successful_builds_for('fix') + expect(builds).to be_kind_of(ActiveRecord::Relation) expect(builds).to be_empty end end -- GitLab