Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
李少辉-开发者
gitlab-foss
提交
13cabe71
G
gitlab-foss
项目概览
李少辉-开发者
/
gitlab-foss
通知
15
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
G
gitlab-foss
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
13cabe71
编写于
8月 03, 2016
作者:
D
Dmitriy Zaporozhets
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Add newlines styleguide for Ruby code
上级
c675bdad
变更
2
显示空白变更内容
内联
并排
Showing
2 changed file
with
104 addition
and
0 deletion
+104
-0
CONTRIBUTING.md
CONTRIBUTING.md
+2
-0
doc/development/newlines_styleguide.md
doc/development/newlines_styleguide.md
+102
-0
未找到文件。
CONTRIBUTING.md
浏览文件 @
13cabe71
...
...
@@ -459,6 +459,7 @@ merge request:
-
multi-line method chaining style
**Option B**
: dot
`.`
on previous line
-
string literal quoting style
**Option A**
: single quoted by default
1.
[
Rails
](
https://github.com/bbatsov/rails-style-guide
)
1.
[
Newlines styleguide
][
newlines-styleguide
]
1.
[
Testing
](
doc/development/testing.md
)
1.
[
CoffeeScript
](
https://github.com/thoughtbot/guides/tree/master/style/coffeescript
)
1.
[
SCSS styleguide
][
scss-styleguide
]
...
...
@@ -530,6 +531,7 @@ available at [http://contributor-covenant.org/version/1/1/0/](http://contributor
[
rss-naming
]:
https://github.com/bbatsov/ruby-style-guide/blob/master/README.md#naming
[
doc-styleguide
]:
doc/development/doc_styleguide.md
"Documentation styleguide"
[
scss-styleguide
]:
doc/development/scss_styleguide.md
"SCSS styleguide"
[
newlines-styleguide
]:
doc/development/newlines_styleguide.md
"Newlines styleguide"
[
gitlab-design
]:
https://gitlab.com/gitlab-org/gitlab-design
[
free Antetype viewer (Mac OSX only)
]:
https://itunes.apple.com/us/app/antetype-viewer/id824152298?mt=12
[
`gitlab8.atype` file
]:
https://gitlab.com/gitlab-org/gitlab-design/tree/master/current/
...
...
doc/development/newlines_styleguide.md
0 → 100644
浏览文件 @
13cabe71
# Newlines styleguide
This style guide recommends best practices for newlines in Ruby code.
## Rule: separate code with newlines only when it makes sense from logic perspectice
```
ruby
# bad
def
method
issue
=
Issue
.
new
issue
.
save
render
json:
issue
end
```
```
ruby
# good
def
method
issue
=
Issue
.
new
issue
.
save
render
json:
issue
end
```
## Rule: separate code and block with newlines
### Newline before block
```
ruby
# bad
def
method
issue
=
Issue
.
new
if
issue
.
save
render
json:
issue
end
end
```
```
ruby
# good
def
method
issue
=
Issue
.
new
if
issue
.
save
render
json:
issue
end
end
```
## Newline after block
```
ruby
# bad
def
method
if
issue
.
save
issue
.
send_email
end
render
json:
issue
end
```
```
ruby
# good
def
method
if
issue
.
save
issue
.
send_email
end
render
json:
issue
end
```
### Exception: no need for newline when code block starts or ends right inside another code block
```
ruby
# bad
def
method
if
issue
if
issue
.
valid?
issue
.
save
end
end
end
```
```
ruby
# good
def
method
if
issue
if
issue
.
valid?
issue
.
save
end
end
end
```
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录