Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
李少辉-开发者
gitlab-foss
提交
0f7cb967
G
gitlab-foss
项目概览
李少辉-开发者
/
gitlab-foss
通知
15
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
G
gitlab-foss
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
0f7cb967
编写于
7月 10, 2017
作者:
F
Felipe Artur
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Fix milestones destroy service
上级
31ada792
变更
2
显示空白变更内容
内联
并排
Showing
2 changed file
with
55 addition
and
2 deletion
+55
-2
app/services/milestones/destroy_service.rb
app/services/milestones/destroy_service.rb
+4
-2
spec/services/milestones/destroy_service_spec.rb
spec/services/milestones/destroy_service_spec.rb
+51
-0
未找到文件。
app/services/milestones/destroy_service.rb
浏览文件 @
0f7cb967
module
Milestones
module
Milestones
class
DestroyService
<
Milestones
::
BaseService
class
DestroyService
<
Milestones
::
BaseService
def
execute
(
milestone
)
def
execute
(
milestone
)
return
unless
milestone
.
is_project_milestone?
Milestone
.
transaction
do
Milestone
.
transaction
do
update_params
=
{
milestone:
nil
}
update_params
=
{
milestone:
nil
}
milestone
.
issues
.
each
do
|
issue
|
milestone
.
issues
.
each
do
|
issue
|
Issues
::
UpdateService
.
new
(
p
rojec
t
,
current_user
,
update_params
).
execute
(
issue
)
Issues
::
UpdateService
.
new
(
p
aren
t
,
current_user
,
update_params
).
execute
(
issue
)
end
end
milestone
.
merge_requests
.
each
do
|
merge_request
|
milestone
.
merge_requests
.
each
do
|
merge_request
|
MergeRequests
::
UpdateService
.
new
(
p
rojec
t
,
current_user
,
update_params
).
execute
(
merge_request
)
MergeRequests
::
UpdateService
.
new
(
p
aren
t
,
current_user
,
update_params
).
execute
(
merge_request
)
end
end
event_service
.
destroy_milestone
(
milestone
,
current_user
)
event_service
.
destroy_milestone
(
milestone
,
current_user
)
...
...
spec/services/milestones/destroy_service_spec.rb
0 → 100644
浏览文件 @
0f7cb967
require
'spec_helper'
describe
Milestones
::
DestroyService
,
services:
true
do
let
(
:user
)
{
create
(
:user
)
}
let
(
:project
)
{
create
(
:project
)
}
let
(
:milestone
)
{
create
(
:milestone
,
title:
'Milestone v1.0'
,
project:
project
)
}
let
(
:issue
)
{
create
(
:issue
,
project:
project
,
milestone:
milestone
)
}
let
(
:merge_request
)
{
create
(
:merge_request
,
source_project:
project
,
milestone:
milestone
)
}
before
do
project
.
team
<<
[
user
,
:master
]
end
def
service
described_class
.
new
(
project
,
user
,
{})
end
describe
'#execute'
do
it
'deletes milestone'
do
service
.
execute
(
milestone
)
expect
{
milestone
.
reload
}.
to
raise_error
ActiveRecord
::
RecordNotFound
end
it
'deletes milestone id from issuables'
do
service
.
execute
(
milestone
)
expect
(
issue
.
reload
.
milestone
).
to
be_nil
expect
(
merge_request
.
reload
.
milestone
).
to
be_nil
end
context
'group milestones'
do
let
(
:group
)
{
create
(
:group
)
}
let
(
:group_milestone
)
{
create
(
:milestone
,
group:
group
)
}
before
do
project
.
update
(
namespace:
group
)
group
.
add_developer
(
user
)
end
it
{
expect
(
service
.
execute
(
group_milestone
)).
to
be_nil
}
it
'does not update milestone issuables'
do
expect
(
MergeRequests
::
UpdateService
).
not_to
receive
(
:new
)
expect
(
Issues
::
UpdateService
).
not_to
receive
(
:new
)
service
.
execute
(
group_milestone
)
end
end
end
end
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录