From 09cf5514133e6493ee943b3d61c63a9f62c432a1 Mon Sep 17 00:00:00 2001 From: Yorick Peterse Date: Mon, 10 Dec 2018 16:43:03 +0100 Subject: [PATCH] Don't allow Danger to fail in CI any more In https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/20654 this job was marked as allowing failures, but this allows developers to ignore the results that Danger produces. Since it's not clear why the job was allowed to fail, and since it's somewhat counter productive, we no longer allow it to fail. --- .gitlab-ci.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 898d740ed63..4ae319d64d7 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -488,7 +488,6 @@ danger-review: <<: *pull-cache image: registry.gitlab.com/gitlab-org/gitlab-build-images:danger stage: test - allow_failure: true dependencies: [] before_script: [] only: -- GitLab