From 0566bbd064e2fd6bf37bffc146a4c48aacf7059a Mon Sep 17 00:00:00 2001 From: Stan Hu Date: Wed, 28 Nov 2018 03:04:11 -0800 Subject: [PATCH] Fix "protected branches only" checkbox not set properly at init The `only_protected_branches` value was being enabled by default even though the checkbox was default off. In EE, this wasn't a problem because there was EE-specific code to update the entire form. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/53515 --- app/assets/javascripts/mirrors/mirror_repos.js | 1 + changelogs/unreleased/sh-fix-mirrors-protected-branches.yml | 5 +++++ 2 files changed, 6 insertions(+) create mode 100644 changelogs/unreleased/sh-fix-mirrors-protected-branches.yml diff --git a/app/assets/javascripts/mirrors/mirror_repos.js b/app/assets/javascripts/mirrors/mirror_repos.js index 0d8f31d6bfc..196b84621b6 100644 --- a/app/assets/javascripts/mirrors/mirror_repos.js +++ b/app/assets/javascripts/mirrors/mirror_repos.js @@ -30,6 +30,7 @@ export default class MirrorRepos { this.$password.on('input.updateUrl', () => this.debouncedUpdateUrl()); this.initMirrorSSH(); + this.updateProtectedBranches(); } initMirrorSSH() { diff --git a/changelogs/unreleased/sh-fix-mirrors-protected-branches.yml b/changelogs/unreleased/sh-fix-mirrors-protected-branches.yml new file mode 100644 index 00000000000..627de25650d --- /dev/null +++ b/changelogs/unreleased/sh-fix-mirrors-protected-branches.yml @@ -0,0 +1,5 @@ +--- +title: Fix "protected branches only" checkbox not set properly at init +merge_request: 23409 +author: +type: fixed -- GitLab