From 01eb0571f0498225c3d75df419b8a50a47739dc8 Mon Sep 17 00:00:00 2001
From: Clement Ho <ClemMakesApps@gmail.com>
Date: Mon, 14 Nov 2016 10:37:55 -0600
Subject: [PATCH] Resolve MR review suggestions

---
 .../filtered_search/filtered_search_bundle.js |  6 ----
 .../filtered_search_manager.js.es6            | 28 +++++++++----------
 .../filtered_search_tokenizer.es6             |  2 +-
 3 files changed, 15 insertions(+), 21 deletions(-)

diff --git a/app/assets/javascripts/filtered_search/filtered_search_bundle.js b/app/assets/javascripts/filtered_search/filtered_search_bundle.js
index 656979ba82f..d188718c5f3 100644
--- a/app/assets/javascripts/filtered_search/filtered_search_bundle.js
+++ b/app/assets/javascripts/filtered_search/filtered_search_bundle.js
@@ -1,4 +1,3 @@
- /* eslint-disable */
  // This is a manifest file that'll be compiled into including all the files listed below.
  // Add new JavaScript code in separate files in this directory and they'll automatically
  // be included in the compiled file accessible from http://example.com/assets/application.js
@@ -6,8 +5,3 @@
  // the compiled file.
  //
  /*= require_tree . */
- 
- (function() {
- 
- }).call(this);
- 
\ No newline at end of file
diff --git a/app/assets/javascripts/filtered_search/filtered_search_manager.js.es6 b/app/assets/javascripts/filtered_search/filtered_search_manager.js.es6
index db414b9755d..26b9d334545 100644
--- a/app/assets/javascripts/filtered_search/filtered_search_manager.js.es6
+++ b/app/assets/javascripts/filtered_search/filtered_search_manager.js.es6
@@ -18,22 +18,22 @@
     param: 'name[]',
   }];
 
-  function clearSearch(event) {
-    event.stopPropagation();
-    event.preventDefault();
+  function clearSearch(e) {
+    e.stopPropagation();
+    e.preventDefault();
 
     document.querySelector('.filtered-search').value = '';
     document.querySelector('.clear-search').classList.add('hidden');
   }
 
-  function toggleClearSearchButton(event) {
+  function toggleClearSearchButton(e) {
     const clearSearchButton = document.querySelector('.clear-search');
 
     if (event.target.value) {
-      clearSearchButton.classList.remove('hidden');
-    } else {
-      clearSearchButton.classList.add('hidden');
-    }
+       clearSearchButton.classList.remove('hidden');
+     } else {
+       clearSearchButton.classList.add('hidden');
+     }
   }
 
   function loadSearchParamsFromURL() {
@@ -97,16 +97,16 @@
       document.querySelector('.clear-search').addEventListener('click', clearSearch);
     }
 
-    processInput(event) {
-      const input = event.target.value;
+    processInput(e) {
+      const input = e.target.value;
       this.tokenizer.processTokens(input);
     }
 
-    checkForEnter(event) {
+    checkForEnter(e) {
       // Enter KeyCode
-      if (event.keyCode === 13) {
-        event.stopPropagation();
-        event.preventDefault();
+      if (e.keyCode === 13) {
+        e.stopPropagation();
+        e.preventDefault();
         this.search();
       }
     }
diff --git a/app/assets/javascripts/filtered_search/filtered_search_tokenizer.es6 b/app/assets/javascripts/filtered_search/filtered_search_tokenizer.es6
index ddb173b2d98..de91081edfa 100644
--- a/app/assets/javascripts/filtered_search/filtered_search_tokenizer.es6
+++ b/app/assets/javascripts/filtered_search/filtered_search_tokenizer.es6
@@ -36,7 +36,7 @@
 
       inputs.forEach((i) => {
         if (incompleteToken) {
-          const prevToken = this.tokens[this.tokens.length - 1];
+          const prevToken = this.tokens.last();
           prevToken.value += ` ${i}`;
 
           // Remove last quotation
-- 
GitLab