提交 85d17a12 编写于 作者: M martin f. krafft 提交者: Junio C Hamano

Escape project names before creating pathinfo URLs

If a project name contains special URL characters like +, gitweb's links
break in subtle ways. The solution is to pass the project name through
esc_url() and using the return value.
Signed-off-by: Nmartin f. krafft <madduck@madduck.net>
Signed-off-by: NJunio C Hamano <gitster@pobox.com>
上级 bbd4c307
......@@ -628,7 +628,7 @@ (%)
my ($use_pathinfo) = gitweb_check_feature('pathinfo');
if ($use_pathinfo) {
# use PATH_INFO for project name
$href .= "/$params{'project'}" if defined $params{'project'};
$href .= "/".esc_url($params{'project'}) if defined $params{'project'};
delete $params{'project'};
# Summary just uses the project path URL
......@@ -2570,7 +2570,7 @@ sub git_header_html {
my $action = $my_uri;
my ($use_pathinfo) = gitweb_check_feature('pathinfo');
if ($use_pathinfo) {
$action .= "/$project";
$action .= "/".esc_url($project);
} else {
$cgi->param("p", $project);
}
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册