From 76f8a302c73d7fe26b2034ab4d1dde64de39c8df Mon Sep 17 00:00:00 2001 From: "Shawn O. Pearce" Date: Wed, 31 Jan 2007 02:24:44 -0500 Subject: [PATCH] Don't coredump on bad refs in update-server-info. Apparently if we are unable to parse an object update-server-info coredumps, as it doesn't bother to check the return value of its call to parse_object. Instead of coredumping, skip the ref. Signed-off-by: Shawn O. Pearce Signed-off-by: Junio C Hamano --- server-info.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/server-info.c b/server-info.c index 6cd38be329..f9be5a7f60 100644 --- a/server-info.c +++ b/server-info.c @@ -10,6 +10,8 @@ static FILE *info_ref_fp; static int add_info_ref(const char *path, const unsigned char *sha1, int flag, void *cb_data) { struct object *o = parse_object(sha1); + if (!o) + return -1; fprintf(info_ref_fp, "%s %s\n", sha1_to_hex(sha1), path); if (o->type == OBJ_TAG) { -- GitLab