From 53de742470bdf160a8412d7a2e9c30545db63fac Mon Sep 17 00:00:00 2001 From: Junio C Hamano Date: Mon, 24 Nov 2014 09:47:07 -0800 Subject: [PATCH] t/README: justify why "! grep foo" is sufficient We require use of test_must_fail to check expected non-zero exit by Git itself, but discourage test_must_fail to be used for checking exit status of non Git commands that are supplied by the system. The current text explains the reason for the former but not the latter. Signed-off-by: Junio C Hamano --- t/README | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/t/README b/t/README index caeeb9dedc..1d51d0e0be 100644 --- a/t/README +++ b/t/README @@ -335,7 +335,8 @@ Don't: dies in an unexpected way (e.g. segfault). On the other hand, don't use test_must_fail for running regular - platform commands; just use '! cmd'. + platform commands; just use '! cmd'. We are not in the business + of verifying that the world given to us sanely works. - use perl without spelling it as "$PERL_PATH". This is to help our friends on Windows where the platform Perl often adds CR before -- GitLab