Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
李少辉-开发者
Brakeman
提交
6d082467
B
Brakeman
项目概览
李少辉-开发者
/
Brakeman
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
B
Brakeman
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
6d082467
编写于
8月 31, 2012
作者:
J
Justin
浏览文件
操作
浏览文件
下载
差异文件
Merge pull request #139 from presidentbeef/fix_redirect_false_negative
Fix `redirect_to` false negative with only_path
上级
5a0eb528
a4216449
变更
3
显示空白变更内容
内联
并排
Showing
3 changed file
with
25 addition
and
19 deletion
+25
-19
lib/brakeman/checks/check_redirect.rb
lib/brakeman/checks/check_redirect.rb
+12
-12
test/apps/rails3/app/controllers/home_controller.rb
test/apps/rails3/app/controllers/home_controller.rb
+8
-2
test/tests/test_rails3.rb
test/tests/test_rails3.rb
+5
-5
未找到文件。
lib/brakeman/checks/check_redirect.rb
浏览文件 @
6d082467
...
...
@@ -95,7 +95,8 @@ class Brakeman::CheckRedirect < Brakeman::BaseCheck
#Checks +redirect_to+ arguments for +only_path => true+ which essentially
#nullifies the danger posed by redirecting with user input
def
only_path?
call
call
.
args
.
each
do
|
arg
|
arg
=
call
.
first_arg
if
hash
?
arg
if
value
=
hash_access
(
arg
,
:
only_path
)
return
true
if
true
?(
value
)
...
...
@@ -103,7 +104,6 @@ class Brakeman::CheckRedirect < Brakeman::BaseCheck
elsif
call?
arg
and
arg
.
method
==
:
url_for
return
check_url_for
(
arg
)
end
end
false
end
...
...
@@ -111,13 +111,13 @@ class Brakeman::CheckRedirect < Brakeman::BaseCheck
#+url_for+ is only_path => true by default. This checks to see if it is
#set to false for some reason.
def
check_url_for
call
call
.
args
.
each
do
|
arg
|
arg
=
call
.
first_arg
if
hash
?
arg
if
value
=
hash_access
(
arg
,
:
only_path
)
return
false
if
false
?(
value
)
end
end
end
true
end
...
...
test/apps/rails3/app/controllers/home_controller.rb
浏览文件 @
6d082467
...
...
@@ -73,8 +73,8 @@ class HomeController < ApplicationController
current_user
.
something
.
something
.
build
(
params
[
:awesome_user
])
end
def
test_only_path
redirect_to
params
[
:user
],
:only_path
=>
true
def
test_only_path
_wrong
redirect_to
params
[
:user
],
:only_path
=>
true
#This should still warn
end
def
test_url_for_only_path
...
...
@@ -92,6 +92,12 @@ class HomeController < ApplicationController
y
+
1
+
2
end
def
test_only_path_correct
params
.
merge!
:only_path
=>
true
redirect_to
params
end
private
def
filter_it
...
...
test/tests/test_rails3.rb
浏览文件 @
6d082467
...
...
@@ -15,7 +15,7 @@ class Rails3Tests < Test::Unit::TestCase
:controller
=>
1
,
:model
=>
5
,
:template
=>
23
,
:warning
=>
29
:warning
=>
30
}
end
...
...
@@ -135,11 +135,11 @@ class Rails3Tests < Test::Unit::TestCase
:file
=>
/products_controller\.rb/
end
def
test_redirect_only_path
assert_
no_
warning
:type
=>
:warning
,
def
test_redirect_only_path
_in_wrong_argument
assert_warning
:type
=>
:warning
,
:warning_type
=>
"Redirect"
,
:line
=>
7
8
,
:message
=>
/^Possible unprotected redirect near line 7
8
: redirect_to\(params\[/
,
:line
=>
7
7
,
:message
=>
/^Possible unprotected redirect near line 7
7
: redirect_to\(params\[/
,
:confidence
=>
0
,
:file
=>
/home_controller\.rb/
end
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录