From 258c221a44a2dd7db74a57362d58c483a40f55e0 Mon Sep 17 00:00:00 2001
From: Haojun Liao <hjliao@taosdata.com>
Date: Tue, 7 Sep 2021 17:11:00 +0800
Subject: [PATCH] [td-255] refactor code.

---
 src/client/src/tscSQLParser.c | 11 ++++-------
 src/client/src/tscSql.c       |  4 ++--
 src/client/src/tscSubquery.c  |  7 +------
 src/inc/taosmsg.h             |  6 ------
 4 files changed, 7 insertions(+), 21 deletions(-)

diff --git a/src/client/src/tscSQLParser.c b/src/client/src/tscSQLParser.c
index 20d14958c8..e4728a410a 100644
--- a/src/client/src/tscSQLParser.c
+++ b/src/client/src/tscSQLParser.c
@@ -8701,13 +8701,10 @@ static int32_t doLoadAllTableMeta(SSqlObj* pSql, SQueryInfo* pQueryInfo, SSqlNod
 
         assert(existVgroupInfo.inUse >= 0);
         SVgroupMsg *pVgroup = &pTableMetaInfo->vgroupList->vgroups[j];
-        memcpy(pVgroup, &existVgroupInfo, sizeof(SVgroupMsg));
-//        pVgroup->numOfEps = existVgroupInfo.numOfEps;
-//        pVgroup->vgId = existVgroupInfo.vgId;
-//        for (int32_t k = 0; k < existVgroupInfo.numOfEps; ++k) {
-//          pVgroup->epAddr[k].port = existVgroupInfo.ep[k].port;
-//          pVgroup->epAddr[k].fqdn = strndup(existVgroupInfo.ep[k].fqdn, TSDB_FQDN_LEN);
-//        }
+
+        pVgroup->numOfEps = existVgroupInfo.numOfEps;
+        pVgroup->vgId = existVgroupInfo.vgId;
+        memcpy(&pVgroup->epAddr, &existVgroupInfo.ep, sizeof(pVgroup->epAddr));
       }
     }
   }
diff --git a/src/client/src/tscSql.c b/src/client/src/tscSql.c
index faa1c2ff41..5fdaad0d66 100644
--- a/src/client/src/tscSql.c
+++ b/src/client/src/tscSql.c
@@ -588,8 +588,8 @@ static bool tscKillQueryInDnode(SSqlObj* pSql) {
     pCmd->command = (pCmd->command > TSDB_SQL_MGMT) ? TSDB_SQL_RETRIEVE : TSDB_SQL_FETCH;
     tscDebug("0x%"PRIx64" send msg to dnode to free qhandle ASAP before free sqlObj, command:%s", pSql->self, sqlCmd[pCmd->command]);
 
-//    tscBuildAndSendRequest(pSql, NULL);
-//    return false;
+    tscBuildAndSendRequest(pSql, NULL);
+    return false;
   }
 
   return true;
diff --git a/src/client/src/tscSubquery.c b/src/client/src/tscSubquery.c
index 1a88270b27..8a52bc776d 100644
--- a/src/client/src/tscSubquery.c
+++ b/src/client/src/tscSubquery.c
@@ -748,7 +748,6 @@ void tscBuildVgroupTableInfo(SSqlObj* pSql, STableMetaInfo* pTableMetaInfo, SArr
       for (int32_t m = 0; m < pvg->numOfVgroups; ++m) {
         if (tt->vgId == pvg->vgroups[m].vgId) {
           memcpy(&info.vgInfo, &pvg->vgroups[m], sizeof(info.vgInfo));
-//          tscSVgroupInfoCopy(&info.vgInfo, &pvg->vgroups[m]);
           break;
         }
       }
@@ -2579,9 +2578,6 @@ int32_t tscHandleMasterSTableQuery(SSqlObj *pSql) {
     
     tscDebug("0x%"PRIx64" sub:0x%"PRIx64" create subquery success. orderOfSub:%d", pSql->self, pNew->self,
         trs->subqueryIndex);
-
-    tfree(trs->localBuffer);
-    tfree(trs);
   }
   
   if (i < pState->numOfSub) {
@@ -2599,8 +2595,7 @@ int32_t tscHandleMasterSTableQuery(SSqlObj *pSql) {
     return pRes->code;
   }
 
-  pSql->fp(pSql->param, pSql, 0);
-//  doConcurrentlySendSubQueries(pSql);
+  doConcurrentlySendSubQueries(pSql);
   return TSDB_CODE_SUCCESS;
 }
 
diff --git a/src/inc/taosmsg.h b/src/inc/taosmsg.h
index 616ee1d972..3c1d89134c 100644
--- a/src/inc/taosmsg.h
+++ b/src/inc/taosmsg.h
@@ -766,12 +766,6 @@ typedef struct SSTableVgroupMsg {
   int32_t numOfTables;
 } SSTableVgroupMsg, SSTableVgroupRspMsg;
 
-//typedef struct {
-//  int32_t       vgId;
-//  int8_t        numOfEps;
-//  SEpAddr1      epAddr[TSDB_MAX_REPLICA];
-//} SVgroupInfo;
-
 typedef struct {
   int32_t    vgId;
   int8_t     numOfEps;
-- 
GitLab