From 1c9430e2c6045296570ffafcc9e264bfe08c9f46 Mon Sep 17 00:00:00 2001
From: Megvii Engine Team <megengine@megvii.com>
Date: Mon, 31 Aug 2020 19:43:35 +0800
Subject: [PATCH] fix(mge/imperative): clear log message

GitOrigin-RevId: 051264cac3eabfdb3d6ccc0a46586b9a4f258bb5
---
 imperative/python/tools/gen_ops.py | 8 ++++++++
 imperative/src/impl/op_trait.cpp   | 2 ++
 2 files changed, 10 insertions(+)

diff --git a/imperative/python/tools/gen_ops.py b/imperative/python/tools/gen_ops.py
index 059efc6c9..7fcdb422a 100755
--- a/imperative/python/tools/gen_ops.py
+++ b/imperative/python/tools/gen_ops.py
@@ -52,6 +52,7 @@ class Context:
         self.indent = 0
         self.generated = []
         self.skipped = []
+        self.generated_signature = set()
 
     def write(self, text, *fmt, indent=0):
         text = textwrap.dedent(text)
@@ -184,6 +185,13 @@ class Context:
             self.skipped.append(name)
             return
 
+        signature = (name, params if isinstance(params, str) else frozenset(params), has_out_dtype, version)
+        if signature in self.generated_signature:
+            self.skipped.append(name)
+            return
+        else:
+            self.generated_signature.add(signature)
+
         body = body or []
         if isinstance(params, str):
             params = [('param', params)]
diff --git a/imperative/src/impl/op_trait.cpp b/imperative/src/impl/op_trait.cpp
index 0d89ad7a6..f36043ca9 100644
--- a/imperative/src/impl/op_trait.cpp
+++ b/imperative/src/impl/op_trait.cpp
@@ -87,12 +87,14 @@ OpTraitRegistry& OpTraitRegistry::finalize() {
     CHECK(infer_output_attrs);
     CHECK(make_backward_graph);
     #undef CHECK
+    #ifdef DEBUG
     if (msg.tellp() > 0) {
         mgb_log_warn(
             "%s op trait missing: %s",
             trait->name ? trait->name : "(anonymous)",
             msg.str().c_str() + 2 /* skip first ", " */);
     }
+    #endif
     return *this;
 }
 
-- 
GitLab