diff --git a/db/blob/db_blob_basic_test.cc b/db/blob/db_blob_basic_test.cc index 56b76ce4ce66ebf9269c8190c45475001f020106..7f027fe3fe97b062b20f7f08b984cb0699a57f84 100644 --- a/db/blob/db_blob_basic_test.cc +++ b/db/blob/db_blob_basic_test.cc @@ -1018,14 +1018,6 @@ TEST_P(DBBlobBasicIOErrorTest, CompactionFilterReadBlob_IOError) { } // namespace ROCKSDB_NAMESPACE -#ifdef ROCKSDB_UNITTESTS_WITH_CUSTOM_OBJECTS_FROM_STATIC_LIBS -extern "C" { -void RegisterCustomObjects(int argc, char** argv); -} -#else -void RegisterCustomObjects(int /*argc*/, char** /*argv*/) {} -#endif // !ROCKSDB_UNITTESTS_WITH_CUSTOM_OBJECTS_FROM_STATIC_LIBS - int main(int argc, char** argv) { ROCKSDB_NAMESPACE::port::InstallStackTraceHandler(); ::testing::InitGoogleTest(&argc, argv); diff --git a/db/blob/db_blob_compaction_test.cc b/db/blob/db_blob_compaction_test.cc index 13d7b6d2881b8a1c0cbd3bb0bd83453576cdcf42..ee4acc4bf19404b8927282427a60c1bf1e771955 100644 --- a/db/blob/db_blob_compaction_test.cc +++ b/db/blob/db_blob_compaction_test.cc @@ -592,14 +592,6 @@ TEST_F(DBBlobCompactionTest, MergeBlobWithBase) { } // namespace ROCKSDB_NAMESPACE -#ifdef ROCKSDB_UNITTESTS_WITH_CUSTOM_OBJECTS_FROM_STATIC_LIBS -extern "C" { -void RegisterCustomObjects(int argc, char** argv); -} -#else -void RegisterCustomObjects(int /*argc*/, char** /*argv*/) {} -#endif // !ROCKSDB_UNITTESTS_WITH_CUSTOM_OBJECTS_FROM_STATIC_LIBS - int main(int argc, char** argv) { ROCKSDB_NAMESPACE::port::InstallStackTraceHandler(); ::testing::InitGoogleTest(&argc, argv); diff --git a/db/blob/db_blob_corruption_test.cc b/db/blob/db_blob_corruption_test.cc index 01d0bf69e14b47703c151d5bb1ec8cb7a8e66a2a..7ac7ce3fc703f20bdbe50246eb1978a6bc7ac647 100644 --- a/db/blob/db_blob_corruption_test.cc +++ b/db/blob/db_blob_corruption_test.cc @@ -74,14 +74,6 @@ TEST_F(DBBlobCorruptionTest, VerifyWholeBlobFileChecksum) { #endif // !ROCKSDB_LITE } // namespace ROCKSDB_NAMESPACE -#ifdef ROCKSDB_UNITTESTS_WITH_CUSTOM_OBJECTS_FROM_STATIC_LIBS -extern "C" { -void RegisterCustomObjects(int argc, char** argv); -} -#else -void RegisterCustomObjects(int /*argc*/, char** /*argv*/) {} -#endif // !ROCKSDB_UNITTESTS_WITH_CUSTOM_OBJECTS_FROM_STATIC_LIBS - int main(int argc, char** argv) { ROCKSDB_NAMESPACE::port::InstallStackTraceHandler(); ::testing::InitGoogleTest(&argc, argv); diff --git a/db/blob/db_blob_index_test.cc b/db/blob/db_blob_index_test.cc index 76c119aba5a9434b88f7ff90117399e9b99b0a6d..b872f48d6858e25c48ac05b646f1d0f3df1014e1 100644 --- a/db/blob/db_blob_index_test.cc +++ b/db/blob/db_blob_index_test.cc @@ -564,14 +564,6 @@ TEST_F(DBBlobIndexTest, IntegratedBlobIterate) { } // namespace ROCKSDB_NAMESPACE -#ifdef ROCKSDB_UNITTESTS_WITH_CUSTOM_OBJECTS_FROM_STATIC_LIBS -extern "C" { -void RegisterCustomObjects(int argc, char** argv); -} -#else -void RegisterCustomObjects(int /*argc*/, char** /*argv*/) {} -#endif // !ROCKSDB_UNITTESTS_WITH_CUSTOM_OBJECTS_FROM_STATIC_LIBS - int main(int argc, char** argv) { ROCKSDB_NAMESPACE::port::InstallStackTraceHandler(); ::testing::InitGoogleTest(&argc, argv); diff --git a/db/column_family_test.cc b/db/column_family_test.cc index cdec7bac96abeaa4ec462b69f374344c688dd153..24e1925e103ce35628594c675dc750b5d8df18c2 100644 --- a/db/column_family_test.cc +++ b/db/column_family_test.cc @@ -3433,14 +3433,6 @@ TEST(ColumnFamilyTest, ValidateBlobGCForceThreshold) { } // namespace ROCKSDB_NAMESPACE -#ifdef ROCKSDB_UNITTESTS_WITH_CUSTOM_OBJECTS_FROM_STATIC_LIBS -extern "C" { -void RegisterCustomObjects(int argc, char** argv); -} -#else -void RegisterCustomObjects(int /*argc*/, char** /*argv*/) {} -#endif // !ROCKSDB_UNITTESTS_WITH_CUSTOM_OBJECTS_FROM_STATIC_LIBS - int main(int argc, char** argv) { ROCKSDB_NAMESPACE::port::InstallStackTraceHandler(); ::testing::InitGoogleTest(&argc, argv); diff --git a/db/compaction/compaction_job_test.cc b/db/compaction/compaction_job_test.cc index 554243c09d60a8804ddf7163a3ff1a1d39f03907..6fee80f6af1873fdbd71f745575fe5737374ef23 100644 --- a/db/compaction/compaction_job_test.cc +++ b/db/compaction/compaction_job_test.cc @@ -21,6 +21,7 @@ #include "db/version_set.h" #include "file/writable_file_writer.h" #include "rocksdb/cache.h" +#include "rocksdb/convenience.h" #include "rocksdb/db.h" #include "rocksdb/file_system.h" #include "rocksdb/options.h" @@ -73,9 +74,7 @@ class CompactionJobTestBase : public testing::Test { protected: CompactionJobTestBase(std::string dbname, const Comparator* ucmp, std::function encode_u64_ts) - : env_(Env::Default()), - fs_(env_->GetFileSystem()), - dbname_(std::move(dbname)), + : dbname_(std::move(dbname)), ucmp_(ucmp), db_options_(), mutable_cf_options_(cf_options_), @@ -91,7 +90,13 @@ class CompactionJobTestBase : public testing::Test { preserve_deletes_seqnum_(0), mock_table_factory_(new mock::MockTableFactory()), error_handler_(nullptr, db_options_, &mutex_), - encode_u64_ts_(std::move(encode_u64_ts)) {} + encode_u64_ts_(std::move(encode_u64_ts)) { + Env* base_env = Env::Default(); + EXPECT_OK( + test::CreateEnvFromSystem(ConfigOptions(), &base_env, &env_guard_)); + env_ = base_env; + fs_ = env_->GetFileSystem(); + } void SetUp() override { EXPECT_OK(env_->CreateDirIfMissing(dbname_)); @@ -386,6 +391,7 @@ class CompactionJobTestBase : public testing::Test { } } + std::shared_ptr env_guard_; Env* env_; std::shared_ptr fs_; std::string dbname_; @@ -1403,6 +1409,7 @@ TEST_F(CompactionJobTimestampTest, SomeKeysExpired) { int main(int argc, char** argv) { ::testing::InitGoogleTest(&argc, argv); + RegisterCustomObjects(argc, argv); return RUN_ALL_TESTS(); } diff --git a/db/compaction/compaction_service_test.cc b/db/compaction/compaction_service_test.cc index 4b70c78229706304b904219c95a4ff5a4c591b64..5a4ff7799c592f2b6405d494ce7e855b4586978c 100644 --- a/db/compaction/compaction_service_test.cc +++ b/db/compaction/compaction_service_test.cc @@ -806,14 +806,6 @@ INSTANTIATE_TEST_CASE_P( } // namespace ROCKSDB_NAMESPACE -#ifdef ROCKSDB_UNITTESTS_WITH_CUSTOM_OBJECTS_FROM_STATIC_LIBS -extern "C" { -void RegisterCustomObjects(int argc, char** argv); -} -#else -void RegisterCustomObjects(int /*argc*/, char** /*argv*/) {} -#endif // !ROCKSDB_UNITTESTS_WITH_CUSTOM_OBJECTS_FROM_STATIC_LIBS - int main(int argc, char** argv) { ROCKSDB_NAMESPACE::port::InstallStackTraceHandler(); ::testing::InitGoogleTest(&argc, argv); diff --git a/db/corruption_test.cc b/db/corruption_test.cc index cabf7e700e547c0b67599d9d410d40bbf9515697..c592de875ac0f28044bb7b83535a1c83a52f8d42 100644 --- a/db/corruption_test.cc +++ b/db/corruption_test.cc @@ -890,14 +890,6 @@ TEST_F(CorruptionTest, VerifyWholeTableChecksum) { } // namespace ROCKSDB_NAMESPACE -#ifdef ROCKSDB_UNITTESTS_WITH_CUSTOM_OBJECTS_FROM_STATIC_LIBS -extern "C" { -void RegisterCustomObjects(int argc, char** argv); -} -#else -void RegisterCustomObjects(int /*argc*/, char** /*argv*/) {} -#endif // !ROCKSDB_UNITTESTS_WITH_CUSTOM_OBJECTS_FROM_STATIC_LIBS - int main(int argc, char** argv) { ROCKSDB_NAMESPACE::port::InstallStackTraceHandler(); ::testing::InitGoogleTest(&argc, argv); diff --git a/db/db_basic_test.cc b/db/db_basic_test.cc index dd788f49d25e4ed376f66a9a7890c63d18b45f0e..622f907a87f3b92565afa4bbca43e1ebb7a019b1 100644 --- a/db/db_basic_test.cc +++ b/db/db_basic_test.cc @@ -3860,14 +3860,6 @@ INSTANTIATE_TEST_CASE_P(DBBasicTestDeadline, DBBasicTestDeadline, std::make_tuple(true, true))); } // namespace ROCKSDB_NAMESPACE -#ifdef ROCKSDB_UNITTESTS_WITH_CUSTOM_OBJECTS_FROM_STATIC_LIBS -extern "C" { -void RegisterCustomObjects(int argc, char** argv); -} -#else -void RegisterCustomObjects(int /*argc*/, char** /*argv*/) {} -#endif // !ROCKSDB_UNITTESTS_WITH_CUSTOM_OBJECTS_FROM_STATIC_LIBS - int main(int argc, char** argv) { ROCKSDB_NAMESPACE::port::InstallStackTraceHandler(); ::testing::InitGoogleTest(&argc, argv); diff --git a/db/db_io_failure_test.cc b/db/db_io_failure_test.cc index 75228b4b1fe12e470b1b8974e866f0ab92e808f3..2a405fd38d4144661a05d5abcceb929e1112cd00 100644 --- a/db/db_io_failure_test.cc +++ b/db/db_io_failure_test.cc @@ -588,5 +588,6 @@ TEST_F(DBIOFailureTest, CompactionSstSyncError) { int main(int argc, char** argv) { ROCKSDB_NAMESPACE::port::InstallStackTraceHandler(); ::testing::InitGoogleTest(&argc, argv); + RegisterCustomObjects(argc, argv); return RUN_ALL_TESTS(); } diff --git a/db/db_sst_test.cc b/db/db_sst_test.cc index 51c9d5c3e359bf053a349fa4f629e5c02f2843f7..29f96a28138b71ba312c854be310e425f56788be 100644 --- a/db/db_sst_test.cc +++ b/db/db_sst_test.cc @@ -1681,14 +1681,6 @@ TEST_F(DBSSTTest, DBWithSFMForBlobFilesAtomicFlush) { } // namespace ROCKSDB_NAMESPACE -#ifdef ROCKSDB_UNITTESTS_WITH_CUSTOM_OBJECTS_FROM_STATIC_LIBS -extern "C" { -void RegisterCustomObjects(int argc, char** argv); -} -#else -void RegisterCustomObjects(int /*argc*/, char** /*argv*/) {} -#endif // ROCKSDB_UNITTESTS_WITH_CUSTOM_OBJECTS_FROM_STATIC_LIBS - int main(int argc, char** argv) { ROCKSDB_NAMESPACE::port::InstallStackTraceHandler(); ::testing::InitGoogleTest(&argc, argv); diff --git a/db/db_test.cc b/db/db_test.cc index 55bc7e815003a5e6a7766874ce2f6eb9c19fd100..c3f1954c6ae3e3f58a7f40d7911580d0bc1da8f7 100644 --- a/db/db_test.cc +++ b/db/db_test.cc @@ -6956,14 +6956,6 @@ TEST_F(DBTest, MemoryUsageWithMaxWriteBufferSizeToMaintain) { } // namespace ROCKSDB_NAMESPACE -#ifdef ROCKSDB_UNITTESTS_WITH_CUSTOM_OBJECTS_FROM_STATIC_LIBS -extern "C" { -void RegisterCustomObjects(int argc, char** argv); -} -#else -void RegisterCustomObjects(int /*argc*/, char** /*argv*/) {} -#endif // !ROCKSDB_UNITTESTS_WITH_CUSTOM_OBJECTS_FROM_STATIC_LIBS - int main(int argc, char** argv) { ROCKSDB_NAMESPACE::port::InstallStackTraceHandler(); ::testing::InitGoogleTest(&argc, argv); diff --git a/db/db_test2.cc b/db/db_test2.cc index 765019c1b32eb568e995b0514ba8802d99ffc67a..d599694dcfcffdaa5452f6b5b58c6fccaf5e3641 100644 --- a/db/db_test2.cc +++ b/db/db_test2.cc @@ -6765,14 +6765,6 @@ TEST_F(DBTest2, RenameDirectory) { } } // namespace ROCKSDB_NAMESPACE -#ifdef ROCKSDB_UNITTESTS_WITH_CUSTOM_OBJECTS_FROM_STATIC_LIBS -extern "C" { -void RegisterCustomObjects(int argc, char** argv); -} -#else -void RegisterCustomObjects(int /*argc*/, char** /*argv*/) {} -#endif // !ROCKSDB_UNITTESTS_WITH_CUSTOM_OBJECTS_FROM_STATIC_LIBS - int main(int argc, char** argv) { ROCKSDB_NAMESPACE::port::InstallStackTraceHandler(); ::testing::InitGoogleTest(&argc, argv); diff --git a/db/db_with_timestamp_basic_test.cc b/db/db_with_timestamp_basic_test.cc index 895413f9cece2d2000294b183b6659b0dce9d7c6..97af468a40b70fde97f570fd32a081733d6721de 100644 --- a/db/db_with_timestamp_basic_test.cc +++ b/db/db_with_timestamp_basic_test.cc @@ -3084,14 +3084,6 @@ INSTANTIATE_TEST_CASE_P( } // namespace ROCKSDB_NAMESPACE -#ifdef ROCKSDB_UNITTESTS_WITH_CUSTOM_OBJECTS_FROM_STATIC_LIBS -extern "C" { -void RegisterCustomObjects(int argc, char** argv); -} -#else -void RegisterCustomObjects(int /*argc*/, char** /*argv*/) {} -#endif // !ROCKSDB_UNITTESTS_WITH_CUSTOM_OBJECTS_FROM_STATIC_LIBS - int main(int argc, char** argv) { ROCKSDB_NAMESPACE::port::InstallStackTraceHandler(); ::testing::InitGoogleTest(&argc, argv); diff --git a/db/db_write_buffer_manager_test.cc b/db/db_write_buffer_manager_test.cc index 7a1eb35b5fcde9c10d38917370d5589004a485fe..c1e8f7100e5894cfc69a29db14d3be409f1175ae 100644 --- a/db/db_write_buffer_manager_test.cc +++ b/db/db_write_buffer_manager_test.cc @@ -785,14 +785,6 @@ INSTANTIATE_TEST_CASE_P(DBWriteBufferManagerTest, DBWriteBufferManagerTest, } // namespace ROCKSDB_NAMESPACE -#ifdef ROCKSDB_UNITTESTS_WITH_CUSTOM_OBJECTS_FROM_STATIC_LIBS -extern "C" { -void RegisterCustomObjects(int argc, char** argv); -} -#else -void RegisterCustomObjects(int /*argc*/, char** /*argv*/) {} -#endif // !ROCKSDB_UNITTESTS_WITH_CUSTOM_OBJECTS_FROM_STATIC_LIBS - int main(int argc, char** argv) { ROCKSDB_NAMESPACE::port::InstallStackTraceHandler(); ::testing::InitGoogleTest(&argc, argv); diff --git a/db/db_write_test.cc b/db/db_write_test.cc index 3b0453bfe63a6c748a01f170e02f5edd6c7e95ae..c2dfd9dcd6ab4072ca894caed27b3dd67aa4d13b 100644 --- a/db/db_write_test.cc +++ b/db/db_write_test.cc @@ -461,5 +461,6 @@ INSTANTIATE_TEST_CASE_P(DBWriteTestInstance, DBWriteTest, int main(int argc, char** argv) { ROCKSDB_NAMESPACE::port::InstallStackTraceHandler(); ::testing::InitGoogleTest(&argc, argv); + RegisterCustomObjects(argc, argv); return RUN_ALL_TESTS(); } diff --git a/db/dbformat_test.cc b/db/dbformat_test.cc index 06c5bb2025e80c39a5ee1ab1e3049627f4bbfe2c..fd7d1d7da8a937d23d3a6c25dbe018d3232ddec1 100644 --- a/db/dbformat_test.cc +++ b/db/dbformat_test.cc @@ -8,7 +8,9 @@ // found in the LICENSE file. See the AUTHORS file for names of contributors. #include "db/dbformat.h" + #include "test_util/testharness.h" +#include "test_util/testutil.h" namespace ROCKSDB_NAMESPACE { @@ -202,5 +204,6 @@ TEST_F(FormatTest, RangeTombstoneSerializeEndKey) { int main(int argc, char** argv) { ::testing::InitGoogleTest(&argc, argv); + RegisterCustomObjects(argc, argv); return RUN_ALL_TESTS(); } diff --git a/db/deletefile_test.cc b/db/deletefile_test.cc index 7b2031781e48ed21dcc27f935c72f42a5b1af75a..b4cf0cbb7aee00f45ff86d970c096da7f9a75393 100644 --- a/db/deletefile_test.cc +++ b/db/deletefile_test.cc @@ -596,14 +596,6 @@ TEST_F(DeleteFileTest, DeleteNonDefaultColumnFamily) { } // namespace ROCKSDB_NAMESPACE -#ifdef ROCKSDB_UNITTESTS_WITH_CUSTOM_OBJECTS_FROM_STATIC_LIBS -extern "C" { -void RegisterCustomObjects(int argc, char** argv); -} -#else -void RegisterCustomObjects(int /*argc*/, char** /*argv*/) {} -#endif // !ROCKSDB_UNITTESTS_WITH_CUSTOM_OBJECTS_FROM_STATIC_LIBS - int main(int argc, char** argv) { ROCKSDB_NAMESPACE::port::InstallStackTraceHandler(); ::testing::InitGoogleTest(&argc, argv); diff --git a/db/external_sst_file_basic_test.cc b/db/external_sst_file_basic_test.cc index 16b6364d44ec726cff377ca55dca82ecf395b342..549171c2c0efe6c484446693668021ca148e770e 100644 --- a/db/external_sst_file_basic_test.cc +++ b/db/external_sst_file_basic_test.cc @@ -1806,14 +1806,6 @@ INSTANTIATE_TEST_CASE_P(ExternalSSTFileBasicTest, ExternalSSTFileBasicTest, } // namespace ROCKSDB_NAMESPACE -#ifdef ROCKSDB_UNITTESTS_WITH_CUSTOM_OBJECTS_FROM_STATIC_LIBS -extern "C" { -void RegisterCustomObjects(int argc, char** argv); -} -#else -void RegisterCustomObjects(int /*argc*/, char** /*argv*/) {} -#endif // ROCKSDB_UNITTESTS_WITH_CUSTOM_OBJECTS_FROM_STATIC_LIBS - int main(int argc, char** argv) { ROCKSDB_NAMESPACE::port::InstallStackTraceHandler(); ::testing::InitGoogleTest(&argc, argv); diff --git a/db/fault_injection_test.cc b/db/fault_injection_test.cc index af9329fbffa2b3db830a8d464f7829bed5388844..86f018f4dc80732731c038e25cf65bde07ed8394 100644 --- a/db/fault_injection_test.cc +++ b/db/fault_injection_test.cc @@ -17,6 +17,7 @@ #include "env/mock_env.h" #include "file/filename.h" #include "rocksdb/cache.h" +#include "rocksdb/convenience.h" #include "rocksdb/db.h" #include "rocksdb/env.h" #include "rocksdb/table.h" @@ -81,7 +82,11 @@ class FaultInjectionTest sync_use_compact_(true), base_env_(nullptr), env_(nullptr), - db_(nullptr) {} + db_(nullptr) { + EXPECT_OK( + test::CreateEnvFromSystem(ConfigOptions(), &system_env_, &env_guard_)); + EXPECT_NE(system_env_, nullptr); + } ~FaultInjectionTest() override { ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); @@ -94,7 +99,7 @@ class FaultInjectionTest return false; } else { if (option_config_ == kMultiLevels) { - base_env_.reset(MockEnv::Create(Env::Default())); + base_env_.reset(MockEnv::Create(system_env_)); } return true; } @@ -146,8 +151,7 @@ class FaultInjectionTest assert(tiny_cache_ == nullptr); assert(env_ == nullptr); - env_ = - new FaultInjectionTestEnv(base_env_ ? base_env_.get() : Env::Default()); + env_ = new FaultInjectionTestEnv(base_env_ ? base_env_.get() : system_env_); options_ = CurrentOptions(); options_.env = env_; @@ -345,6 +349,10 @@ class FaultInjectionTest ASSERT_OK(static_cast(db_->GetRootDB())->TEST_WaitForCompact()); ASSERT_OK(db_->Put(WriteOptions(), "", "")); } + + private: + Env* system_env_; + std::shared_ptr env_guard_; }; class FaultInjectionTestSplitted : public FaultInjectionTest {}; @@ -552,5 +560,6 @@ INSTANTIATE_TEST_CASE_P( int main(int argc, char** argv) { ::testing::InitGoogleTest(&argc, argv); + RegisterCustomObjects(argc, argv); return RUN_ALL_TESTS(); } diff --git a/db/obsolete_files_test.cc b/db/obsolete_files_test.cc index 1595b7283d711618065729debf5fbde74b35ca80..83dd2f03f822a4e04d8691677fffbec0f3206f13 100644 --- a/db/obsolete_files_test.cc +++ b/db/obsolete_files_test.cc @@ -308,14 +308,6 @@ TEST_F(ObsoleteFilesTest, BlobFiles) { } // namespace ROCKSDB_NAMESPACE -#ifdef ROCKSDB_UNITTESTS_WITH_CUSTOM_OBJECTS_FROM_STATIC_LIBS -extern "C" { -void RegisterCustomObjects(int argc, char** argv); -} -#else -void RegisterCustomObjects(int /*argc*/, char** /*argv*/) {} -#endif // !ROCKSDB_UNITTESTS_WITH_CUSTOM_OBJECTS_FROM_STATIC_LIBS - int main(int argc, char** argv) { ROCKSDB_NAMESPACE::port::InstallStackTraceHandler(); ::testing::InitGoogleTest(&argc, argv); diff --git a/table/sst_file_reader_test.cc b/table/sst_file_reader_test.cc index d1394b9382e0e83f8d2e13b5e26fbbf64390764c..aa047ce8834916b0dfdd35ddd5c799905d666d7f 100644 --- a/table/sst_file_reader_test.cc +++ b/table/sst_file_reader_test.cc @@ -415,14 +415,6 @@ TEST_F(SstFileReaderTimestampTest, TimestampSizeMismatch) { } // namespace ROCKSDB_NAMESPACE -#ifdef ROCKSDB_UNITTESTS_WITH_CUSTOM_OBJECTS_FROM_STATIC_LIBS -extern "C" { - void RegisterCustomObjects(int argc, char** argv); -} -#else -void RegisterCustomObjects(int /*argc*/, char** /*argv*/) {} -#endif // !ROCKSDB_UNITTESTS_WITH_CUSTOM_OBJECTS_FROM_STATIC_LIBS - int main(int argc, char** argv) { ROCKSDB_NAMESPACE::port::InstallStackTraceHandler(); ::testing::InitGoogleTest(&argc, argv); diff --git a/test_util/testutil.cc b/test_util/testutil.cc index 9c72972eecc31ac07f615efd3bfc65850447861e..986b8d184053eda82349ad48e07ba6d78646866d 100644 --- a/test_util/testutil.cc +++ b/test_util/testutil.cc @@ -30,6 +30,10 @@ #include "test_util/sync_point.h" #include "util/random.h" +#ifndef ROCKSDB_UNITTESTS_WITH_CUSTOM_OBJECTS_FROM_STATIC_LIBS +void RegisterCustomObjects(int /*argc*/, char** /*argv*/) {} +#endif + namespace ROCKSDB_NAMESPACE { namespace test { diff --git a/test_util/testutil.h b/test_util/testutil.h index 70943829329ffdf258659cd8b9ea1ea4ec3fd569..7edf187f4696895526cd1e7a141a16bd50b906fd 100644 --- a/test_util/testutil.h +++ b/test_util/testutil.h @@ -25,6 +25,14 @@ #include "table/internal_iterator.h" #include "util/mutexlock.h" +#ifdef ROCKSDB_UNITTESTS_WITH_CUSTOM_OBJECTS_FROM_STATIC_LIBS +extern "C" { +void RegisterCustomObjects(int argc, char** argv); +} +#else +void RegisterCustomObjects(int argc, char** argv); +#endif // !ROCKSDB_UNITTESTS_WITH_CUSTOM_OBJECTS_FROM_STATIC_LIBS + namespace ROCKSDB_NAMESPACE { class FileSystem; class MemTableRepFactory; diff --git a/tools/ldb_cmd_test.cc b/tools/ldb_cmd_test.cc index 90cd08a8a95a0222af1da6618603f761e45b0ed6..cac39250b03b184a1f58d0b27a10cc4e916bfff1 100644 --- a/tools/ldb_cmd_test.cc +++ b/tools/ldb_cmd_test.cc @@ -970,14 +970,6 @@ TEST_F(LdbCmdTest, RenameDbAndLoadOptions) { } } // namespace ROCKSDB_NAMESPACE -#ifdef ROCKSDB_UNITTESTS_WITH_CUSTOM_OBJECTS_FROM_STATIC_LIBS -extern "C" { -void RegisterCustomObjects(int argc, char** argv); -} -#else -void RegisterCustomObjects(int /*argc*/, char** /*argv*/) {} -#endif // !ROCKSDB_UNITTESTS_WITH_CUSTOM_OBJECTS_FROM_STATIC_LIBS - int main(int argc, char** argv) { ROCKSDB_NAMESPACE::port::InstallStackTraceHandler(); ::testing::InitGoogleTest(&argc, argv); diff --git a/tools/sst_dump_test.cc b/tools/sst_dump_test.cc index 3cbfcd3cc3d0945db87dd2ca08377601b10e27fa..fdc372c245660d6bc2dee52f216f51e3c6bc2890 100644 --- a/tools/sst_dump_test.cc +++ b/tools/sst_dump_test.cc @@ -397,14 +397,6 @@ TEST_F(SSTDumpToolTest, RawOutput) { } // namespace ROCKSDB_NAMESPACE -#ifdef ROCKSDB_UNITTESTS_WITH_CUSTOM_OBJECTS_FROM_STATIC_LIBS -extern "C" { -void RegisterCustomObjects(int argc, char** argv); -} -#else -void RegisterCustomObjects(int /*argc*/, char** /*argv*/) {} -#endif // !ROCKSDB_UNITTESTS_WITH_CUSTOM_OBJECTS_FROM_STATIC_LIBS - int main(int argc, char** argv) { ROCKSDB_NAMESPACE::port::InstallStackTraceHandler(); ::testing::InitGoogleTest(&argc, argv);