From ad25b1afb98294551a997fc7969d7d6ed58fb200 Mon Sep 17 00:00:00 2001 From: vrqq Date: Thu, 18 Feb 2021 16:32:28 -0800 Subject: [PATCH] Update win_logger.cc : assert failed when return value not checked. (-DROCKSDB_ASSERT_STATUS_CHECKED) (#7955) Summary: Ignore return value on WinLogger::CloseInternal() when build with -DROCKSDB_ASSERT_STATUS_CHECKED on windows. It's a good way to ignore check here? Pull Request resolved: https://github.com/facebook/rocksdb/pull/7955 Reviewed By: jay-zhuang Differential Revision: D26524145 Pulled By: ajkr fbshipit-source-id: f2f643e94cde9772617c68b658fb529fffebd8ce --- port/win/win_logger.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/port/win/win_logger.cc b/port/win/win_logger.cc index 352e38a59..c1ca97717 100644 --- a/port/win/win_logger.cc +++ b/port/win/win_logger.cc @@ -56,7 +56,7 @@ void WinLogger::DebugWriter(const char* str, int len) { } } -WinLogger::~WinLogger() { CloseInternal(); } +WinLogger::~WinLogger() { CloseInternal().PermitUncheckedError(); } Status WinLogger::CloseImpl() { return CloseInternal(); -- GitLab