From 9e7fda8299c4f299faf95c54cd8e7c9b5e03b2df Mon Sep 17 00:00:00 2001 From: Islam AbdelRahman Date: Wed, 12 Oct 2016 20:11:30 -0700 Subject: [PATCH] Fix arcanist Summary: Set no_proxy to fix arcanist Test Plan: will check if tests are triggered Reviewers: arahut, yiwu, lightmark, andrewkr, sdong Reviewed By: sdong Subscribers: andrewkr, dhruba Differential Revision: https://reviews.facebook.net/D65001 --- arcanist_util/config/RocksDBCommonHelper.php | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/arcanist_util/config/RocksDBCommonHelper.php b/arcanist_util/config/RocksDBCommonHelper.php index 60b9333c3..d235bc9b4 100644 --- a/arcanist_util/config/RocksDBCommonHelper.php +++ b/arcanist_util/config/RocksDBCommonHelper.php @@ -25,6 +25,7 @@ function postURL($diffID, $url) { $cmd = 'echo \'{"diff_id": "' . $diffID . '", ' . '"name":"click here for sandcastle tests for D' . $diffID . '", ' . '"link":"' . $url . '"}\' | ' + . 'no_proxy=facebook.com,tfbnw.net,fb.com ' . 'http_proxy=fwdproxy.any.facebook.com:8080 ' . 'https_proxy=fwdproxy.any.facebook.com:8080 arc call-conduit ' . 'differential.updateunitresults'; @@ -40,6 +41,7 @@ function buildUpdateTestStatusCmd($diffID, $test, $status) { $cmd = 'echo \'{"diff_id": "' . $diffID . '", ' . '"name":"' . $test . '", ' . '"result":"' . $status . '"}\' | ' + . 'no_proxy=facebook.com,tfbnw.net,fb.com ' . 'http_proxy=fwdproxy.any.facebook.com:8080 ' . 'https_proxy=fwdproxy.any.facebook.com:8080 arc call-conduit ' . 'differential.updateunitresults'; @@ -106,7 +108,8 @@ function getSteps($applyDiff, $diffID, $username, $test) { // Patch the code (keep your fingures crossed). $patch = array( "name" => "Patch " . $diffID, - "shell" => "HTTPS_PROXY=fwdproxy:8080 arc --arcrc-file ~/.arcrc " + "shell" => "no_proxy=facebook.com,tfbnw.net,fb.com " + ."HTTPS_PROXY=fwdproxy:8080 arc --arcrc-file ~/.arcrc " . "patch --nocommit --diff " . $diffID, "user" => "root" ); -- GitLab