From 9ccf1bd3e24f59bdaa934de5a42b3598a00fb66a Mon Sep 17 00:00:00 2001 From: Yueh-Hsuan Chiang Date: Tue, 25 Aug 2015 16:45:23 -0700 Subject: [PATCH] Correct the comment for GetProperty() API. Summary: "rocksdb.aggregated-table-properties" and "rocksdb.aggregated-table-properties-at-level" should belong to GetProperty() instead of GetIntProperty(), but the comment mistakenly classifies them to GetIntProperty(). This patch fix this comment error. Test Plan: no code change. Reviewers: sdong, anthony, IslamAbdelRahman, igor Reviewed By: igor Subscribers: dhruba Differential Revision: https://reviews.facebook.net/D45561 --- include/rocksdb/db.h | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/include/rocksdb/db.h b/include/rocksdb/db.h index 3824e5b7f..a5640ebb7 100644 --- a/include/rocksdb/db.h +++ b/include/rocksdb/db.h @@ -334,6 +334,12 @@ class DB { // "rocksdb.estimate-pending-compaction-bytes" - estimated total number of // bytes compaction needs to rewrite the data to get all levels down // to under target size. Not valid for other compactions than level-based. +// "rocksdb.aggregated-table-properties" - returns a string representation of +// the aggregated table properties of the target column family. +// "rocksdb.aggregated-table-properties-at-level", same as the previous +// one but only returns the aggregated table properties of the specified +// level "N" at the target column family. +// replaced by the target level. #ifndef ROCKSDB_LITE struct Properties { static const std::string kNumFilesAtLevelPrefix; @@ -396,9 +402,6 @@ class DB { // "rocksdb.total-sst-files-size" // "rocksdb.base-level" // "rocksdb.estimate-pending-compaction-bytes" - // "rocksdb.aggregated-table-properties" - // "rocksdb.aggregated-table-properties-at-levelN", where "N" should be - // replaced by the target level. virtual bool GetIntProperty(ColumnFamilyHandle* column_family, const Slice& property, uint64_t* value) = 0; virtual bool GetIntProperty(const Slice& property, uint64_t* value) { -- GitLab