From 8189c184ec0b595ca77e7de153fe1f0648484976 Mon Sep 17 00:00:00 2001 From: Sagar Vemuri Date: Tue, 22 Jan 2019 11:10:05 -0800 Subject: [PATCH] Remove unused Blob WAL filter (#4896) Summary: Remove unused blob WAL filter so that users are not confused. I was initially under the impression that we have WAL Filter support in BlobDB. Pull Request resolved: https://github.com/facebook/rocksdb/pull/4896 Differential Revision: D13725709 Pulled By: sagar0 fbshipit-source-id: f997d7546e138a474036e88b957907cc714327f1 --- utilities/blob_db/blob_db_impl.cc | 7 ------- utilities/blob_db/blob_db_impl.h | 15 --------------- 2 files changed, 22 deletions(-) diff --git a/utilities/blob_db/blob_db_impl.cc b/utilities/blob_db/blob_db_impl.cc index 5dc9f01f0..c878ae2d5 100644 --- a/utilities/blob_db/blob_db_impl.cc +++ b/utilities/blob_db/blob_db_impl.cc @@ -45,13 +45,6 @@ int kBlockBasedTableVersionFormat = 2; namespace rocksdb { namespace blob_db { -WalFilter::WalProcessingOption BlobReconcileWalFilter::LogRecordFound( - unsigned long long /*log_number*/, const std::string& /*log_file_name*/, - const WriteBatch& /*batch*/, WriteBatch* /*new_batch*/, - bool* /*batch_changed*/) { - return WalFilter::WalProcessingOption::kContinueProcessing; -} - bool BlobFileComparator::operator()( const std::shared_ptr& lhs, const std::shared_ptr& rhs) const { diff --git a/utilities/blob_db/blob_db_impl.h b/utilities/blob_db/blob_db_impl.h index 8d5148def..8678ee9d4 100644 --- a/utilities/blob_db/blob_db_impl.h +++ b/utilities/blob_db/blob_db_impl.h @@ -47,21 +47,6 @@ struct BlobCompactionContext; class BlobDBImpl; class BlobFile; -// this implements the callback from the WAL which ensures that the -// blob record is present in the blob log. If fsync/fdatasync in not -// happening on every write, there is the probability that keys in the -// blob log can lag the keys in blobs -// TODO(yiwu): implement the WAL filter. -class BlobReconcileWalFilter : public WalFilter { - public: - virtual WalFilter::WalProcessingOption LogRecordFound( - unsigned long long log_number, const std::string& log_file_name, - const WriteBatch& batch, WriteBatch* new_batch, - bool* batch_changed) override; - - virtual const char* Name() const override { return "BlobDBWalReconciler"; } -}; - // Comparator to sort "TTL" aware Blob files based on the lower value of // TTL range. struct BlobFileComparatorTTL { -- GitLab