From 6db57bc37f2edee1f1ac8030593659b83d33a7d9 Mon Sep 17 00:00:00 2001 From: Peter Dillinger Date: Fri, 6 Dec 2019 10:25:40 -0800 Subject: [PATCH] Disable new Bloom filter assertion (#6128) Summary: A longstanding bug in our C interface can trigger this assertion; see issue https://github.com/facebook/rocksdb/issues/6129. Disabling the assertion for now (for 6.6.0) and will re-enable on fix of that bug. Pull Request resolved: https://github.com/facebook/rocksdb/pull/6128 Differential Revision: D18854899 Pulled By: pdillinger fbshipit-source-id: 9eb5294b9f11b208dc1a8cc148aaa31e47ff892b --- table/block_based/filter_policy.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/table/block_based/filter_policy.cc b/table/block_based/filter_policy.cc index 38a6e9f83..7d43a8fab 100644 --- a/table/block_based/filter_policy.cc +++ b/table/block_based/filter_policy.cc @@ -443,7 +443,8 @@ void BloomFilterPolicy::CreateFilter(const Slice* keys, int n, std::string* dst) const { // We should ideally only be using this deprecated interface for // appropriately constructed BloomFilterPolicy - assert(mode_ == kDeprecatedBlock); + // FIXME disabled because of bug in C interface; see issue #6129 + //assert(mode_ == kDeprecatedBlock); // Compute bloom filter size (in both bits and bytes) uint32_t bits = static_cast(n * whole_bits_per_key_); -- GitLab