From 64a0082c69fc22efd3fa1e6979a7addfbbcc2585 Mon Sep 17 00:00:00 2001 From: Islam AbdelRahman Date: Mon, 15 Aug 2016 14:04:40 -0700 Subject: [PATCH] Fix DBSSTest::AddExternalSstFileSkipSnapshot valgrind fail Summary: Fix the test by releasing the last snapshot Test Plan: run the test under valgrind Reviewers: andrewkr, yiwu, lightmark, sdong Reviewed By: sdong Subscribers: andrewkr, dhruba Differential Revision: https://reviews.facebook.net/D62091 --- db/db_sst_test.cc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/db/db_sst_test.cc b/db/db_sst_test.cc index 374a8649c..388bf0a7d 100644 --- a/db/db_sst_test.cc +++ b/db/db_sst_test.cc @@ -1345,6 +1345,8 @@ TEST_F(DBSSTTest, AddExternalSstFileSkipSnapshot) { ASSERT_OK(db_->AddFile(std::vector(1, file3_info), false, true)); ASSERT_EQ(Get(Key(300)), Key(300) + ("_val")); ASSERT_EQ(Get(Key(300), s2), Key(300) + ("_val")); + + db_->ReleaseSnapshot(s2); } TEST_F(DBSSTTest, AddExternalSstFileMultiThreaded) { -- GitLab