From 327c4807a7fe8532326323e2753670daf06a0f6b Mon Sep 17 00:00:00 2001 From: Maysam Yabandeh Date: Mon, 22 Jul 2019 20:01:25 -0700 Subject: [PATCH] Disable refresh snapshot feature by default (#5606) Summary: There are concerns about the correctness of this patch. Disabling by default until the concerns are resolved. Pull Request resolved: https://github.com/facebook/rocksdb/pull/5606 Differential Revision: D16428064 Pulled By: maysamyabandeh fbshipit-source-id: a89280f0ea85796c9c9dfbfd9a8e91dad9b000b3 --- HISTORY.md | 2 +- include/rocksdb/options.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/HISTORY.md b/HISTORY.md index efd49f642..19f4ce129 100644 --- a/HISTORY.md +++ b/HISTORY.md @@ -20,7 +20,7 @@ * Added new APIs ExportColumnFamily() and CreateColumnFamilyWithImport() to support export and import of a Column Family. https://github.com/facebook/rocksdb/issues/3469 ### New Features -* Add an option `snap_refresh_nanos` (default to 0.1s) to periodically refresh the snapshot list in compaction jobs. Assign to 0 to disable the feature. +* Add an option `snap_refresh_nanos` (default to 0) to periodically refresh the snapshot list in compaction jobs. Assign to 0 to disable the feature. * Add an option `unordered_write` which trades snapshot guarantees with higher write throughput. When used with WRITE_PREPARED transactions with two_write_queues=true, it offers higher throughput with however no compromise on guarantees. * Allow DBImplSecondary to remove memtables with obsolete data after replaying MANIFEST and WAL. * Add an option `failed_move_fall_back_to_copy` (default is true) for external SST ingestion. When `move_files` is true and hard link fails, ingestion falls back to copy if `failed_move_fall_back_to_copy` is true. Otherwise, ingestion reports an error. diff --git a/include/rocksdb/options.h b/include/rocksdb/options.h index 234af6a31..35c275565 100644 --- a/include/rocksdb/options.h +++ b/include/rocksdb/options.h @@ -275,10 +275,10 @@ struct ColumnFamilyOptions : public AdvancedColumnFamilyOptions { // this option helps reducing the cpu usage of long-running compactions. The // feature is disabled when max_subcompactions is greater than one. // - // Default: 0.1s + // Default: 0 // // Dynamically changeable through SetOptions() API - uint64_t snap_refresh_nanos = 100 * 1000 * 1000; // 0.1s + uint64_t snap_refresh_nanos = 0; // Disable automatic compactions. Manual compactions can still // be issued on this column family -- GitLab