From 210b49cac9b08b11981444141c3d12318231578c Mon Sep 17 00:00:00 2001 From: Yanqin Jin Date: Tue, 30 Apr 2019 08:09:13 -0700 Subject: [PATCH] Disable pipelined write in atomic flush stress test (#5266) Summary: Since currently pipelined write allows one thread to perform memtable writes while another thread is traversing the `flush_scheduler_`, it will cause an assertion failure in `FlushScheduler::Clear`. To unblock crash recoery tests, we temporarily disable pipelined write when atomic flush is enabled. Pull Request resolved: https://github.com/facebook/rocksdb/pull/5266 Differential Revision: D15142285 Pulled By: riversand963 fbshipit-source-id: a0c20fe4ac543e08feaed602414f982054df7831 --- tools/db_crashtest.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/db_crashtest.py b/tools/db_crashtest.py index a1a9ecb66..a27abe8cf 100644 --- a/tools/db_crashtest.py +++ b/tools/db_crashtest.py @@ -136,6 +136,8 @@ atomic_flush_params = { # use small value for write_buffer_size so that RocksDB triggers flush # more frequently "write_buffer_size": 1024 * 1024, + # disable pipelined write when test_atomic_flush is true + "enable_pipelined_write": 0, } -- GitLab