From 1daff8f85a59a454303091d0b0bea85d4f8c0a31 Mon Sep 17 00:00:00 2001 From: sdong Date: Tue, 27 Aug 2019 17:54:18 -0700 Subject: [PATCH] crash_test to skip compaction TTL for FIFO compaction. (#5749) Summary: https://github.com/facebook/rocksdb/pull/5741 added compaction TTL to crash test, but it causes assertion fails for FIFO compaction. Disable this combination for now while we debug the assertion failure. Pull Request resolved: https://github.com/facebook/rocksdb/pull/5749 Test Plan: Run crash test and observe that when compaction_style=2, compaction_ttl is always 0. Differential Revision: D17078292 fbshipit-source-id: 446821a3b9739956094d5e4f9be1251a15b57f5d --- tools/db_crashtest.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tools/db_crashtest.py b/tools/db_crashtest.py index a62a7b685..73a46b424 100644 --- a/tools/db_crashtest.py +++ b/tools/db_crashtest.py @@ -170,6 +170,10 @@ def finalize_and_sanitize(src_params): # with open_files = -1 dest_params["compaction_ttl"] = 0 dest_params["periodic_compaction_seconds"] = 0 + if dest_params.get("compaction_style", 0) == 2: + # Disable compaction TTL in FIFO compaction, because right + # now assertion failures are triggered. + dest_params["compaction_ttl"] = 0 return dest_params -- GitLab