From 124fbd96d815f97f66cb1658935185744665ffee Mon Sep 17 00:00:00 2001
From: Levi Tamasi <ltamasi@fb.com>
Date: Wed, 5 Aug 2020 16:24:06 -0700
Subject: [PATCH] Remove assertion from FaultInjectionTestFS::NewDirectory
 (#7220)

Summary:
FaultInjectionTestFS::NewDirectory currently asserts that the directory
creation on the target filesystem succeeds. This is actually not
guaranteed since there might be a legitimate I/O error when creating the
directory. The patch removes this assertion.

Pull Request resolved: https://github.com/facebook/rocksdb/pull/7220

Test Plan: `make check`

Reviewed By: zhichao-cao

Differential Revision: D22957990

Pulled By: ltamasi

fbshipit-source-id: b2e221320d8ce7235cb4897ef5936072412a25b6
---
 utilities/fault_injection_fs.cc | 1 -
 1 file changed, 1 deletion(-)

diff --git a/utilities/fault_injection_fs.cc b/utilities/fault_injection_fs.cc
index 5ee901523..3f7be199e 100644
--- a/utilities/fault_injection_fs.cc
+++ b/utilities/fault_injection_fs.cc
@@ -227,7 +227,6 @@ IOStatus FaultInjectionTestFS::NewDirectory(
     std::unique_ptr<FSDirectory>* result, IODebugContext* dbg) {
   std::unique_ptr<FSDirectory> r;
   IOStatus io_s = target()->NewDirectory(name, options, &r, dbg);
-  assert(io_s.ok());
   if (!io_s.ok()) {
     return io_s;
   }
-- 
GitLab