From 0b1ffe2e1d2db08a0f366a417039eaabf4fed497 Mon Sep 17 00:00:00 2001
From: Yueh-Hsuan Chiang <yhchiang@fb.com>
Date: Tue, 23 Jun 2015 16:32:59 -0700
Subject: [PATCH] Remove -Wl,--no-as-needed flag when making shared_lib in OSX
 and IOS

Summary:
Remove -Wl,--no-as-needed flag when making shared_lib in OSX and IOS as
those environment doe not have compile option --no-as-needed

  ld: unknown option: --no-as-needed
  clang: error: linker command failed with exit code 1 (use -v to see invocation)

Test Plan: make shared_lib

Reviewers: meyering, igor

Reviewed By: igor

Subscribers: dhruba, leveldb

Differential Revision: https://reviews.facebook.net/D40353
---
 Makefile                          | 2 +-
 build_tools/build_detect_platform | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/Makefile b/Makefile
index 1e2d48e5e..3f29f73ee 100644
--- a/Makefile
+++ b/Makefile
@@ -349,7 +349,7 @@ endif
 
 $(SHARED4):
 	$(CXX) $(PLATFORM_SHARED_LDFLAGS)$(SHARED3) $(CXXFLAGS) $(PLATFORM_SHARED_CFLAGS) $(LIB_SOURCES) \
-		-Wl,--no-as-needed $(LDFLAGS) -o $@
+		$(LDFLAGS) -o $@
 
 endif  # PLATFORM_SHARED_EXT
 
diff --git a/build_tools/build_detect_platform b/build_tools/build_detect_platform
index 35ca03d36..d0769e338 100755
--- a/build_tools/build_detect_platform
+++ b/build_tools/build_detect_platform
@@ -92,7 +92,7 @@ CROSS_COMPILE=
 PLATFORM_CCFLAGS=
 PLATFORM_LDFLAGS="$PLATFORM_LDFLAGS"
 PLATFORM_SHARED_EXT="so"
-PLATFORM_SHARED_LDFLAGS="-shared -Wl,-soname -Wl,"
+PLATFORM_SHARED_LDFLAGS="-Wl,--no-as-needed -shared -Wl,-soname -Wl,"
 PLATFORM_SHARED_CFLAGS="-fPIC"
 PLATFORM_SHARED_VERSIONED=true
 
-- 
GitLab