提交 9645f33c 编写于 作者: A Ahmed Ashour 提交者: skylot

fix: bitwise or/and with non-boolean (#628) (PR #629)

上级 336d6ce1
...@@ -12,6 +12,7 @@ import jadx.core.dex.instructions.ArithNode; ...@@ -12,6 +12,7 @@ import jadx.core.dex.instructions.ArithNode;
import jadx.core.dex.instructions.ArithOp; import jadx.core.dex.instructions.ArithOp;
import jadx.core.dex.instructions.IfNode; import jadx.core.dex.instructions.IfNode;
import jadx.core.dex.instructions.IfOp; import jadx.core.dex.instructions.IfOp;
import jadx.core.dex.instructions.args.ArgType;
import jadx.core.dex.instructions.args.InsnWrapArg; import jadx.core.dex.instructions.args.InsnWrapArg;
import jadx.core.dex.instructions.args.LiteralArg; import jadx.core.dex.instructions.args.LiteralArg;
import jadx.core.dex.instructions.args.RegisterArg; import jadx.core.dex.instructions.args.RegisterArg;
...@@ -221,6 +222,7 @@ public final class IfCondition { ...@@ -221,6 +222,7 @@ public final class IfCondition {
break; break;
case ARITH: case ARITH:
if (c.getB().getType() == ArgType.BOOLEAN) {
ArithOp arithOp = ((ArithNode) wrapInsn).getOp(); ArithOp arithOp = ((ArithNode) wrapInsn).getOp();
if (arithOp == ArithOp.OR || arithOp == ArithOp.AND) { if (arithOp == ArithOp.OR || arithOp == ArithOp.AND) {
IfOp ifOp = c.getInsn().getOp(); IfOp ifOp = c.getInsn().getOp();
...@@ -237,6 +239,7 @@ public final class IfCondition { ...@@ -237,6 +239,7 @@ public final class IfCondition {
Arrays.asList(new IfCondition(new Compare(if1)), Arrays.asList(new IfCondition(new Compare(if1)),
new IfCondition(new Compare(if2)))); new IfCondition(new Compare(if2))));
} }
}
break; break;
default: default:
......
package jadx.tests.integration.conditions;
import static jadx.tests.api.utils.JadxMatchers.containsOne;
import static org.hamcrest.MatcherAssert.assertThat;
import org.junit.jupiter.api.Test;
import jadx.core.dex.nodes.ClassNode;
import jadx.tests.api.IntegrationTest;
public class TestConditions17 extends IntegrationTest {
public static class TestCls {
public static final int SOMETHING = 2;
public static void test(int a) {
if ((a & SOMETHING) != 0) {
print(1);
}
print(2);
}
public static void print(Object o) {
}
}
@Test
public void test() {
ClassNode cls = getClassNode(TestCls.class);
String code = cls.getCode().toString();
assertThat(code, containsOne(" & "));
}
}
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册