diff --git a/ribbon-core/src/main/java/com/netflix/client/RequestSpecificRetryHandler.java b/ribbon-core/src/main/java/com/netflix/client/RequestSpecificRetryHandler.java index de4d174090d11b857edfbe1df17112908933aa50..8d3fab65ede0f921023b7d3b6b89a025b5928d7c 100644 --- a/ribbon-core/src/main/java/com/netflix/client/RequestSpecificRetryHandler.java +++ b/ribbon-core/src/main/java/com/netflix/client/RequestSpecificRetryHandler.java @@ -35,10 +35,10 @@ public class RequestSpecificRetryHandler implements RetryHandler { this.okToRetryOnAllErrors = okToRetryOnAllErrors; this.fallback = baseRetryHandler; if (requestConfig != null) { - Optional.ofNullable(requestConfig.get(CommonClientConfigKey.MaxAutoRetries)).ifPresent( + requestConfig.getIfSet(CommonClientConfigKey.MaxAutoRetries).ifPresent( value -> retrySameServer = value ); - Optional.ofNullable(requestConfig.get(CommonClientConfigKey.MaxAutoRetriesNextServer)).ifPresent( + requestConfig.getIfSet(CommonClientConfigKey.MaxAutoRetriesNextServer).ifPresent( value -> retryNextServer = value ); } diff --git a/ribbon-core/src/main/java/com/netflix/client/config/ReloadableClientConfig.java b/ribbon-core/src/main/java/com/netflix/client/config/ReloadableClientConfig.java index e2b16c2932d2ad3777392087b3faa4e5d6de166c..c712ad85e43ef060c23e5db449597c853a2ed324 100644 --- a/ribbon-core/src/main/java/com/netflix/client/config/ReloadableClientConfig.java +++ b/ribbon-core/src/main/java/com/netflix/client/config/ReloadableClientConfig.java @@ -456,10 +456,10 @@ public abstract class ReloadableClientConfig implements IClientConfig { private String generateToString() { return "ClientConfig:" + internalProperties.entrySet().stream() .map(t -> { - if (t.getKey().key().endsWith("Password")) { + if (t.getKey().key().endsWith("Password") && t.getValue().isPresent()) { return t.getKey() + ":***"; } - return t.getKey() + ":" + t.getValue(); + return t.getKey() + ":" + t.getValue().orElse(null); }) .collect(Collectors.joining(", ")); } diff --git a/ribbon-eureka/src/main/java/com/netflix/niws/loadbalancer/DiscoveryEnabledNIWSServerList.java b/ribbon-eureka/src/main/java/com/netflix/niws/loadbalancer/DiscoveryEnabledNIWSServerList.java index 5c6080c32efe96187b8e500793b30e715685e1fd..882563601e9029d482235f0506c0af9f29e802d2 100644 --- a/ribbon-eureka/src/main/java/com/netflix/niws/loadbalancer/DiscoveryEnabledNIWSServerList.java +++ b/ribbon-eureka/src/main/java/com/netflix/niws/loadbalancer/DiscoveryEnabledNIWSServerList.java @@ -117,7 +117,7 @@ public class DiscoveryEnabledNIWSServerList extends AbstractServerList key, boolean defaultValue) { - return Optional.ofNullable(overriddenClientConfig) - .map(config -> config.get(key)) - .orElse(defaultValue); - } - @Override protected int getDefaultPortFromScheme(String scheme) { int port = super.getDefaultPortFromScheme(scheme); @@ -489,7 +482,7 @@ public class RestClient extends AbstractLoadBalancerAwareClient deriveSchemeAndPortFromPartialUri(URI uri) { - boolean isSecure = getBooleanFromConfig(ncc, CommonClientConfigKey.IsSecure, this.isSecure); + boolean isSecure = ncc.get(CommonClientConfigKey.IsSecure, this.isSecure); String scheme = uri.getScheme(); if (scheme != null) { isSecure = scheme.equalsIgnoreCase("https"); @@ -507,7 +500,7 @@ public class RestClient extends AbstractLoadBalancerAwareClient(scheme, port); + return new Pair<>(scheme, port); } private HttpResponse execute(HttpRequest.Verb verb, URI uri, @@ -516,7 +509,7 @@ public class RestClient extends AbstractLoadBalancerAwareClient config.get(CommonClientConfigKey.FollowRedirects, bFollowRedirects)) + .flatMap(config -> config.getIfSet(CommonClientConfigKey.FollowRedirects)) .orElse(bFollowRedirects); restClient.setFollowRedirects(bbFollowRedirects); diff --git a/ribbon-transport/src/main/java/com/netflix/ribbon/transport/netty/http/LoadBalancingHttpClient.java b/ribbon-transport/src/main/java/com/netflix/ribbon/transport/netty/http/LoadBalancingHttpClient.java index d7fe11a1769301f2040e2b00e928576ace3c8ce3..83f1bc6861c99257f81ac640d1e41837ad4dc8bc 100644 --- a/ribbon-transport/src/main/java/com/netflix/ribbon/transport/netty/http/LoadBalancingHttpClient.java +++ b/ribbon-transport/src/main/java/com/netflix/ribbon/transport/netty/http/LoadBalancingHttpClient.java @@ -456,7 +456,7 @@ public class LoadBalancingHttpClient extends LoadBalancingRxClientWithPool } int port = uri.getPort(); if (port < 0) { - if (Optional.ofNullable(clientConfig.get(IClientConfigKey.Keys.IsSecure)).orElse(false)) { + if (clientConfig.get(IClientConfigKey.Keys.IsSecure, false)) { port = 443; } else { port = 80;