From 643c2167cba4bb0a7681ccc7a6f01593bb47d72f Mon Sep 17 00:00:00 2001 From: Nikita Potapenko Date: Wed, 4 Sep 2019 17:49:44 +0300 Subject: [PATCH] Rename test class (dotnet/core-setup#7950) Commit migrated from https://github.com/dotnet/core-setup/commit/33d05af6ff91b7f8f0badb97f643ffd9d6c48521 --- docs/installer/design-docs/host-testing.md | 2 +- ...GivenThatICareAboutNativeUnitTests.cs => NativeUnitTests.cs} | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) rename src/installer/test/HostActivation.Tests/{GivenThatICareAboutNativeUnitTests.cs => NativeUnitTests.cs} (94%) diff --git a/docs/installer/design-docs/host-testing.md b/docs/installer/design-docs/host-testing.md index 0f7e6c3b676..56279f79a3c 100644 --- a/docs/installer/design-docs/host-testing.md +++ b/docs/installer/design-docs/host-testing.md @@ -32,7 +32,7 @@ Cons: Going forward we would keep these tests and add new ones to provide true End-to-End coverage. ### Native API tests -Small portion of the tests actually call specific exports on `hostfxr` or `hostpolicy` directly to test these. All these tests are in the `HostActivation` project under the `GivenThatICareAboutNativeHostApi` test class. +Small portion of the tests actually call specific exports on `hostfxr` or `hostpolicy` directly to test these. All these tests are in the `HostActivation` project under the `NativeHostApis` test class. These tests use a special test application (managed) which invokes the selected exports through PInvokes and performs the testing. The `HostActivation` test only prepares this app and executes it, looking for pieces of its output to verify the outcome. Ideally we would migrate these over time to the proposed Component tests infra. diff --git a/src/installer/test/HostActivation.Tests/GivenThatICareAboutNativeUnitTests.cs b/src/installer/test/HostActivation.Tests/NativeUnitTests.cs similarity index 94% rename from src/installer/test/HostActivation.Tests/GivenThatICareAboutNativeUnitTests.cs rename to src/installer/test/HostActivation.Tests/NativeUnitTests.cs index 4cfc640ab94..ecffdbacf40 100644 --- a/src/installer/test/HostActivation.Tests/GivenThatICareAboutNativeUnitTests.cs +++ b/src/installer/test/HostActivation.Tests/NativeUnitTests.cs @@ -10,7 +10,7 @@ namespace Microsoft.DotNet.CoreSetup.Test.HostActivation.NativeUnitTests { - public class GivenThatICareAboutNativeUnitTests + public class NativeUnitTests { [Fact] public void Native_Test_Fx_Ver() -- GitLab