From d5c676a5135648443cbb5a10b8b26e5215fc6f99 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E5=A4=8F=E5=85=8B?=
 <31796712+FrankXMX@users.noreply.github.com>
Date: Fri, 23 Sep 2022 13:10:17 +0800
Subject: [PATCH] =?UTF-8?q?=E8=B0=83=E6=95=B4=E6=96=87=E6=A1=A3=E6=A0=BC?=
 =?UTF-8?q?=E5=BC=8F&=E7=BC=96=E8=AF=91=E8=AD=A6=E5=91=8A=20(#85)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* fix -Wunused-function

* 调整文档格式
---
 docs/how_to_dev_miniob_by_vscode.md   | 9 ++++-----
 src/observer/net/server.cpp           | 1 -
 src/observer/sql/stmt/select_stmt.cpp | 2 +-
 3 files changed, 5 insertions(+), 7 deletions(-)

diff --git a/docs/how_to_dev_miniob_by_vscode.md b/docs/how_to_dev_miniob_by_vscode.md
index 29d7de4..014754b 100644
--- a/docs/how_to_dev_miniob_by_vscode.md
+++ b/docs/how_to_dev_miniob_by_vscode.md
@@ -24,11 +24,10 @@ UBUNTU_CODENAME=focal
 2. cmake
 3. make
 4. gcc/g++
-
-3. libevent
-5. googletest
-6. jsoncpp
-7. git
+5. libevent
+6. googletest
+7. jsoncpp
+8. git
 
 ## 获取代码
 ```bash
diff --git a/src/observer/net/server.cpp b/src/observer/net/server.cpp
index 47e2e52..e6c887f 100644
--- a/src/observer/net/server.cpp
+++ b/src/observer/net/server.cpp
@@ -189,7 +189,6 @@ int Server::send(ConnectionContext *client, const char *buf, int data_len)
   TimerStat writeStat(*write_socket_metric_);
 
   MUTEX_LOCK(&client->mutex);
-  int wlen = 0;
   int ret = common::writen(client->fd, buf, data_len);
   if (ret < 0) {
     LOG_ERROR("Failed to send data back to client. ret=%d, error=%s", ret, strerror(errno));
diff --git a/src/observer/sql/stmt/select_stmt.cpp b/src/observer/sql/stmt/select_stmt.cpp
index 580c857..9d433c8 100644
--- a/src/observer/sql/stmt/select_stmt.cpp
+++ b/src/observer/sql/stmt/select_stmt.cpp
@@ -46,7 +46,7 @@ RC SelectStmt::create(Db *db, const Selects &select_sql, Stmt *&stmt)
   // collect tables in `from` statement
   std::vector<Table *> tables;
   std::unordered_map<std::string, Table *> table_map;
-  for (int i = 0; i < select_sql.relation_num; i++) {
+  for (size_t i = 0; i < select_sql.relation_num; i++) {
     const char *table_name = select_sql.relations[i];
     if (nullptr == table_name) {
       LOG_WARN("invalid argument. relation name is null. index=%d", i);
-- 
GitLab