diff --git a/src/librustc_trans/trans/base.rs b/src/librustc_trans/trans/base.rs index 61e81d75607cf702caae9432d3e1b245a5271b45..a5e00060295edeba6801029cc47e2de30576f3e8 100644 --- a/src/librustc_trans/trans/base.rs +++ b/src/librustc_trans/trans/base.rs @@ -2032,6 +2032,23 @@ pub fn update_linkage(ccx: &CrateContext, } } +fn set_global_section(ccx: &CrateContext, llval: ValueRef, i: &ast::Item) { + match attr::first_attr_value_str_by_name(&i.attrs, + "link_section") { + Some(sect) => { + if contains_null(§) { + ccx.sess().fatal(&format!("Illegal null byte in link_section value: `{}`", + §)); + } + unsafe { + let buf = CString::new(sect.as_bytes()).unwrap(); + llvm::LLVMSetSection(llval, buf.as_ptr()); + } + }, + None => () + } +} + pub fn trans_item(ccx: &CrateContext, item: &ast::Item) { let _icx = push_ctxt("trans_item"); @@ -2054,6 +2071,7 @@ pub fn trans_item(ccx: &CrateContext, item: &ast::Item) { } else { trans_fn(ccx, &**decl, &**body, llfn, empty_substs, item.id, &item.attrs); } + set_global_section(ccx, llfn, item); update_linkage(ccx, llfn, Some(item.id), if is_origin { OriginalTranslation } else { InlinedCopy }); @@ -2103,6 +2121,7 @@ pub fn trans_item(ccx: &CrateContext, item: &ast::Item) { v.visit_expr(&**expr); let g = consts::trans_static(ccx, m, expr, item.id, &item.attrs); + set_global_section(ccx, g, item); update_linkage(ccx, g, Some(item.id), OriginalTranslation); }, ast::ItemForeignMod(ref foreign_mod) => { @@ -2381,21 +2400,6 @@ pub fn get_item_val(ccx: &CrateContext, id: ast::NodeId) -> ValueRef { _ => ccx.sess().bug("get_item_val: weird result in table") }; - match attr::first_attr_value_str_by_name(&i.attrs, - "link_section") { - Some(sect) => { - if contains_null(§) { - ccx.sess().fatal(&format!("Illegal null byte in link_section value: `{}`", - §)); - } - unsafe { - let buf = CString::new(sect.as_bytes()).unwrap(); - llvm::LLVMSetSection(v, buf.as_ptr()); - } - }, - None => () - } - v } diff --git a/src/test/codegen/link_section.rs b/src/test/codegen/link_section.rs new file mode 100644 index 0000000000000000000000000000000000000000..99b43552b0de4ed8325162742e94cf1f40bde6e1 --- /dev/null +++ b/src/test/codegen/link_section.rs @@ -0,0 +1,36 @@ +// Copyright 2015 The Rust Project Developers. See the COPYRIGHT +// file at the top-level directory of this distribution and at +// http://rust-lang.org/COPYRIGHT. +// +// Licensed under the Apache License, Version 2.0 or the MIT license +// , at your +// option. This file may not be copied, modified, or distributed +// except according to those terms. + +// compile-flags: -C no-prepopulate-passes + +// CHECK: @VAR1 = constant i32 1, section ".test_one" +#[no_mangle] +#[link_section = ".test_one"] +pub static VAR1: u32 = 1; + +pub enum E { + A(u32), + B(f32) +} + +// CHECK: @VAR2 = constant {{.*}} { i32 0, i32 666, {{.*}} }, section ".test_two" +#[no_mangle] +#[link_section = ".test_two"] +pub static VAR2: E = E::A(666); + +// CHECK: @VAR3 = constant {{.*}} { i32 1, float 1.000000e+00, {{.*}} }, section ".test_three" +#[no_mangle] +#[link_section = ".test_three"] +pub static VAR3: E = E::B(1.); + +// CHECK: define void @fn1() {{.*}} section ".test_four" { +#[no_mangle] +#[link_section = ".test_four"] +pub fn fn1() {}