diff --git a/compiler/rustc_privacy/src/lib.rs b/compiler/rustc_privacy/src/lib.rs index 02ea34ea9743f93d1906421577fde829ac355e8e..910249ecc479ef61235f803b6de1dac4f9203167 100644 --- a/compiler/rustc_privacy/src/lib.rs +++ b/compiler/rustc_privacy/src/lib.rs @@ -159,9 +159,9 @@ fn visit_abstract_const_expr( self.visit_const(leaf) } ACNode::Cast(_, ty) => self.visit_ty(ty), - ACNode::Binop(..) - | ACNode::UnaryOp(..) - | ACNode::FunctionCall(_, _) => ControlFlow::CONTINUE, + ACNode::Binop(..) | ACNode::UnaryOp(..) | ACNode::FunctionCall(_, _) => { + ControlFlow::CONTINUE + } }) } diff --git a/compiler/rustc_trait_selection/src/traits/const_evaluatable.rs b/compiler/rustc_trait_selection/src/traits/const_evaluatable.rs index 77fe1f514d9019d11178d182c6e350c1061dcdf9..7d69ec54bdf0228b92a4884504b67dc3dda33458 100644 --- a/compiler/rustc_trait_selection/src/traits/const_evaluatable.rs +++ b/compiler/rustc_trait_selection/src/traits/const_evaluatable.rs @@ -102,9 +102,9 @@ enum FailureKind { ControlFlow::CONTINUE } - Node::Binop(_, _, _) - | Node::UnaryOp(_, _) - | Node::FunctionCall(_, _) => ControlFlow::CONTINUE, + Node::Binop(_, _, _) | Node::UnaryOp(_, _) | Node::FunctionCall(_, _) => { + ControlFlow::CONTINUE + } }); match failure_kind { @@ -348,8 +348,8 @@ fn recurse_build(&mut self, node: thir::ExprId) -> Result &ExprKind::PlaceTypeAscription { source, .. } | &ExprKind::ValueTypeAscription { source, .. } => self.recurse_build(source)?, - // subtle: associated consts are literals this arm handles - // `::ASSOC` as well as `12` + // subtle: associated consts are literals this arm handles + // `::ASSOC` as well as `12` &ExprKind::Literal { literal, .. } | &ExprKind::StaticRef { literal, .. } => self.add_node(Node::Leaf(literal), node.span), @@ -381,10 +381,10 @@ fn recurse_build(&mut self, node: thir::ExprId) -> Result // } // ``` ExprKind::Block { body: thir::Block { stmts: box [], expr: Some(e), .. }} => self.recurse_build(*e)?, - // ExprKind::Use happens when a `hir::ExprKind::Cast` is a + // ExprKind::Use happens when a `hir::ExprKind::Cast` is a // "coercion cast" i.e. using a coercion or is a no-op. // this is important so that `N as usize as usize` doesnt unify with `N as usize` - &ExprKind::Use { source} + &ExprKind::Use { source} | &ExprKind::Cast { source } => { let arg = self.recurse_build(source)?; self.add_node(Node::Cast(arg, node.ty), node.span) @@ -404,7 +404,7 @@ fn recurse_build(&mut self, node: thir::ExprId) -> Result | ExprKind::Field { .. } | ExprKind::ConstBlock { .. } | ExprKind::Adt(_) => return self.error( - Some(node.span), + Some(node.span), "unsupported operation in generic constant, this may be supported in the future", ).map(|never| never), @@ -417,7 +417,7 @@ fn recurse_build(&mut self, node: thir::ExprId) -> Result | ExprKind::Assign { .. } | ExprKind::LogicalOp { .. } | ExprKind::Unary { .. } // - | ExprKind::Binary { .. } // we handle valid unary/binary ops above + | ExprKind::Binary { .. } // we handle valid unary/binary ops above | ExprKind::Break { .. } | ExprKind::Continue { .. } | ExprKind::If { .. } @@ -592,16 +592,14 @@ pub(super) fn try_unify<'tcx>( && iter::zip(a_args, b_args) .all(|(&an, &bn)| try_unify(tcx, a.subtree(an), b.subtree(bn))) } - (Node::Cast(a_operand, a_ty), Node::Cast(b_operand, b_ty)) - if (a_ty == b_ty) => - { + (Node::Cast(a_operand, a_ty), Node::Cast(b_operand, b_ty)) if (a_ty == b_ty) => { try_unify(tcx, a.subtree(a_operand), b.subtree(b_operand)) } // use this over `_ => false` to make adding variants to `Node` less error prone - (Node::Cast(..), _) - | (Node::FunctionCall(..), _) - | (Node::UnaryOp(..), _) - | (Node::Binop(..), _) + (Node::Cast(..), _) + | (Node::FunctionCall(..), _) + | (Node::UnaryOp(..), _) + | (Node::Binop(..), _) | (Node::Leaf(..), _) => false, } } diff --git a/compiler/rustc_trait_selection/src/traits/object_safety.rs b/compiler/rustc_trait_selection/src/traits/object_safety.rs index d9ea2591553582a1e91e09eaf3c0a2e1e61903c4..63bd10994b1aca0bd20626cb4047a65495240a6b 100644 --- a/compiler/rustc_trait_selection/src/traits/object_safety.rs +++ b/compiler/rustc_trait_selection/src/traits/object_safety.rs @@ -844,9 +844,9 @@ fn visit_unevaluated_const( self.visit_const(leaf) } Node::Cast(_, ty) => self.visit_ty(ty), - Node::Binop(..) - | Node::UnaryOp(..) - | Node::FunctionCall(_, _) => ControlFlow::CONTINUE, + Node::Binop(..) | Node::UnaryOp(..) | Node::FunctionCall(_, _) => { + ControlFlow::CONTINUE + } }) } else { ControlFlow::CONTINUE