diff --git a/src/librustc/middle/lint.rs b/src/librustc/middle/lint.rs index 1ac14dfc4b1e5d35fa425fa88f13491146c1c2d0..e1602ee0896dbdb18bb6cd99a24c1909da4df950 100644 --- a/src/librustc/middle/lint.rs +++ b/src/librustc/middle/lint.rs @@ -942,10 +942,9 @@ fn visit_item(&mut self, it: @ast::item, _: ()) { // trait (which was already linted) ast::item_impl(_, Some(*), _, _) => return, - ast::item_trait(*) if it.vis == ast::public => { - self.check_attrs(it.attrs, it.id, it.span, - ~"missing documentation for a trait"); - } + ast::item_trait(*) if it.vis != ast::public => return, + ast::item_trait(*) => self.check_attrs(it.attrs, it.id, it.span, + ~"missing documentation for a trait"), ast::item_fn(*) if it.vis == ast::public => { self.check_attrs(it.attrs, it.id, it.span, diff --git a/src/test/compile-fail/lint-missing-doc.rs b/src/test/compile-fail/lint-missing-doc.rs index 22710ad90e873ad87341b15ef52e5f60552c29a6..463fd352c5a7ba45584959748b2bd4e469f2d2d7 100644 --- a/src/test/compile-fail/lint-missing-doc.rs +++ b/src/test/compile-fail/lint-missing-doc.rs @@ -45,10 +45,9 @@ pub trait C {} //~ ERROR: missing documentation #[allow(missing_doc)] pub trait D {} trait Bar { - /// dox fn foo(); - fn foo2(); //~ ERROR: missing documentation - fn foo3(); //~ ERROR: missing documentation + fn foo_with_impl() { + } } impl Foo {