From 99901bdbc435fdf6768b392c171204dd7281162b Mon Sep 17 00:00:00 2001 From: Brian Anderson Date: Sat, 2 Apr 2011 19:12:00 -0400 Subject: [PATCH] Add FIXMEs around type handling in trans_if, trans_alt --- src/comp/middle/trans.rs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/comp/middle/trans.rs b/src/comp/middle/trans.rs index 809a268a478..2e4f1d85118 100644 --- a/src/comp/middle/trans.rs +++ b/src/comp/middle/trans.rs @@ -3086,6 +3086,7 @@ fn trans_if(@block_ctxt cx, @ast.expr cond, // If we have an else expression, then the entire // if expression can have a non-nil type. + // FIXME: This isn't quite right, particularly re: dynamic types auto expr_ty = ty.expr_ty(elexpr); if (ty.type_has_dynamic_size(expr_ty)) { expr_llty = T_typaram_ptr(cx.fcx.ccx.tn); @@ -3576,6 +3577,7 @@ fn trans_alt(@block_ctxt cx, @ast.expr expr, auto default_res = trans_fail(default_cx, expr.span, "non-exhaustive match failure"); + // FIXME: This isn't quite right, particularly re: dynamic types auto expr_ty = ty.ann_to_type(ann); auto expr_llty; if (ty.type_has_dynamic_size(expr_ty)) { -- GitLab