From 576888466dcdfd7a03f48262bd10c922ec89f575 Mon Sep 17 00:00:00 2001
From: Matt Pharr <matt@pharr.org>
Date: Mon, 8 Feb 2021 06:38:13 -0800
Subject: [PATCH] Improve Sampler test

---
 src/pbrt/samplers_test.cpp | 19 +++++++++++--------
 1 file changed, 11 insertions(+), 8 deletions(-)

diff --git a/src/pbrt/samplers_test.cpp b/src/pbrt/samplers_test.cpp
index 0454bfb..f47043e 100644
--- a/src/pbrt/samplers_test.cpp
+++ b/src/pbrt/samplers_test.cpp
@@ -100,16 +100,19 @@ static void checkElementary(const char *name, std::vector<Point2f> samples,
 }
 
 static void checkElementarySampler(const char *name, SamplerHandle sampler,
-                                   int logSamples) {
+                                   int logSamples, int res = 1) {
     // Get all of the samples for a pixel.
     int spp = sampler.SamplesPerPixel();
     std::vector<Point2f> samples;
-    for (int i = 0; i < spp; ++i) {
-        sampler.StartPixelSample(Point2i(0, 0), i);
-        samples.push_back(sampler.GetPixel2D());
-    }
+    for (Point2i p : Bounds2i(Point2i(0, 0), Point2i(res, res))) {
+        samples.clear();
+        for (int i = 0; i < spp; ++i) {
+            sampler.StartPixelSample(p, i);
+            samples.push_back(sampler.GetPixel2D());
+        }
 
-    checkElementary(name, samples, logSamples);
+        checkElementary(name, samples, logSamples);
+    }
 }
 
 // TODO: check Halton (where the elementary intervals are (2^i, 3^j)).
@@ -128,8 +131,8 @@ TEST(ZSobolSampler, ElementaryIntervals) {
          {RandomizeStrategy::None, RandomizeStrategy::Owen, RandomizeStrategy::PermuteDigits})
         for (int logSamples = 2; logSamples <= 10; ++logSamples)
             checkElementarySampler("ZSobolSampler",
-                                   new ZSobolSampler(1 << logSamples, Point2i(100, 100), rand),
-                                   logSamples);
+                                   new ZSobolSampler(1 << logSamples, Point2i(10, 10), rand),
+                                   logSamples, 1);
 }
 
 TEST(SobolUnscrambledSampler, ElementaryIntervals) {
-- 
GitLab