From d4047f72613eeb5249839a2aedb50c772f8a27ea Mon Sep 17 00:00:00 2001 From: antirez Date: Tue, 10 Feb 2015 14:47:45 +0100 Subject: [PATCH] Faster memory efficiency test. This test on Linux was extremely slow, since in Tcl we can't enable easily tcp-nodelay, so the busy loop used to take *a lot* with bigger writes. Fixed using pipelining. --- tests/unit/memefficiency.tcl | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/tests/unit/memefficiency.tcl b/tests/unit/memefficiency.tcl index 14e135ce..7ca9a705 100644 --- a/tests/unit/memefficiency.tcl +++ b/tests/unit/memefficiency.tcl @@ -1,15 +1,20 @@ proc test_memory_efficiency {range} { r flushall + set rd [redis_deferring_client] set base_mem [s used_memory] set written 0 for {set j 0} {$j < 10000} {incr j} { set key key:$j set val [string repeat A [expr {int(rand()*$range)}]] - r set $key $val + $rd set $key $val incr written [string length $key] incr written [string length $val] incr written 2 ;# A separator is the minimum to store key-value data. } + for {set j 0} {$j < 10000} {incr j} { + $rd read ; # Discard replies + } + set current_mem [s used_memory] set used [expr {$current_mem-$base_mem}] set efficiency [expr {double($written)/$used}] -- GitLab