提交 834a9b8c 编写于 作者: E Eric Van Hensbergen 提交者: Linus Torvalds

[PATCH] 9p: fix fid behavior on failed remove

Based on a bug report from Russ Ross <russruss@gmail.com>

According to the spec:

"The remove request asks the file server both to remove the file
 represented by fid and to clunk the fid, even if the remove fails."

but the Linux client seems to expect the fid to be valid after a failed
remove attempt.  Specifically, I'm getting this behavior when attempting to
remove a non-empty directory.
Signed-off-by: NEric Van Hensbergen <ericvh@gmail.com>
Signed-off-by: NAndrew Morton <akpm@osdl.org>
Signed-off-by: NLinus Torvalds <torvalds@osdl.org>
上级 1f525f16
...@@ -434,10 +434,10 @@ static int v9fs_remove(struct inode *dir, struct dentry *file, int rmdir) ...@@ -434,10 +434,10 @@ static int v9fs_remove(struct inode *dir, struct dentry *file, int rmdir)
result = v9fs_t_remove(v9ses, fid, &fcall); result = v9fs_t_remove(v9ses, fid, &fcall);
if (result < 0) { if (result < 0) {
PRINT_FCALL_ERROR("remove fails", fcall); PRINT_FCALL_ERROR("remove fails", fcall);
} else { }
v9fs_put_idpool(fid, &v9ses->fidpool); v9fs_put_idpool(fid, &v9ses->fidpool);
v9fs_fid_destroy(v9fid); v9fs_fid_destroy(v9fid);
}
kfree(fcall); kfree(fcall);
return result; return result;
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册