diff --git a/net/tipc/bcast.c b/net/tipc/bcast.c index eadba62afa85dcd9463f5eddd08704539fa63488..2c5f5443354af5dd50e7f88d0e38e2b804058ece 100644 --- a/net/tipc/bcast.c +++ b/net/tipc/bcast.c @@ -35,11 +35,13 @@ * POSSIBILITY OF SUCH DAMAGE. */ +#include #include "socket.h" #include "msg.h" #include "bcast.h" #include "name_distr.h" -#include "core.h" +#include "link.h" +#include "node.h" #define MAX_PKT_DEFAULT_MCAST 1500 /* bcast link max packet size (fixed) */ #define BCLINK_WIN_DEFAULT 50 /* bcast link window size (default) */ @@ -47,34 +49,101 @@ const char tipc_bclink_name[] = "broadcast-link"; +/** + * struct tipc_bcbearer_pair - a pair of bearers used by broadcast link + * @primary: pointer to primary bearer + * @secondary: pointer to secondary bearer + * + * Bearers must have same priority and same set of reachable destinations + * to be paired. + */ + +struct tipc_bcbearer_pair { + struct tipc_bearer *primary; + struct tipc_bearer *secondary; +}; + +#define BCBEARER MAX_BEARERS + +/** + * struct tipc_bcbearer - bearer used by broadcast link + * @bearer: (non-standard) broadcast bearer structure + * @media: (non-standard) broadcast media structure + * @bpairs: array of bearer pairs + * @bpairs_temp: temporary array of bearer pairs used by tipc_bcbearer_sort() + * @remains: temporary node map used by tipc_bcbearer_send() + * @remains_new: temporary node map used tipc_bcbearer_send() + * + * Note: The fields labelled "temporary" are incorporated into the bearer + * to avoid consuming potentially limited stack space through the use of + * large local variables within multicast routines. Concurrent access is + * prevented through use of the spinlock "bcast_lock". + */ +struct tipc_bcbearer { + struct tipc_bearer bearer; + struct tipc_media media; + struct tipc_bcbearer_pair bpairs[MAX_BEARERS]; + struct tipc_bcbearer_pair bpairs_temp[TIPC_MAX_LINK_PRI + 1]; + struct tipc_node_map remains; + struct tipc_node_map remains_new; +}; + +/** + * struct tipc_bc_base - link used for broadcast messages + * @lock: spinlock governing access to structure + * @link: (non-standard) broadcast link structure + * @node: (non-standard) node structure representing b'cast link's peer node + * @bcast_nodes: map of broadcast-capable nodes + * @retransmit_to: node that most recently requested a retransmit + * + * Handles sequence numbering, fragmentation, bundling, etc. + */ +struct tipc_bc_base { + spinlock_t lock; /* spinlock protecting broadcast structs */ + struct tipc_link link; + struct tipc_node node; + struct sk_buff_head arrvq; + struct sk_buff_head inputq; + struct tipc_node_map bcast_nodes; + struct tipc_node *retransmit_to; +}; + +/** + * tipc_nmap_equal - test for equality of node maps + */ +static int tipc_nmap_equal(struct tipc_node_map *nm_a, + struct tipc_node_map *nm_b) +{ + return !memcmp(nm_a, nm_b, sizeof(*nm_a)); +} + static void tipc_nmap_diff(struct tipc_node_map *nm_a, struct tipc_node_map *nm_b, struct tipc_node_map *nm_diff); static void tipc_nmap_add(struct tipc_node_map *nm_ptr, u32 node); static void tipc_nmap_remove(struct tipc_node_map *nm_ptr, u32 node); - static void tipc_bclink_lock(struct net *net) { struct tipc_net *tn = net_generic(net, tipc_net_id); - spin_lock_bh(&tn->bclink->lock); + spin_lock_bh(&tn->bcbase->lock); } static void tipc_bclink_unlock(struct net *net) { struct tipc_net *tn = net_generic(net, tipc_net_id); - spin_unlock_bh(&tn->bclink->lock); + spin_unlock_bh(&tn->bcbase->lock); } void tipc_bclink_input(struct net *net) { struct tipc_net *tn = net_generic(net, tipc_net_id); - tipc_sk_mcast_rcv(net, &tn->bclink->arrvq, &tn->bclink->inputq); + tipc_sk_mcast_rcv(net, &tn->bcbase->arrvq, &tn->bcbase->inputq); } -uint tipc_bclink_get_mtu(void) +uint tipc_bcast_get_mtu(void) { return MAX_PKT_DEFAULT_MCAST; } @@ -99,7 +168,7 @@ void tipc_bclink_add_node(struct net *net, u32 addr) struct tipc_net *tn = net_generic(net, tipc_net_id); tipc_bclink_lock(net); - tipc_nmap_add(&tn->bclink->bcast_nodes, addr); + tipc_nmap_add(&tn->bcbase->bcast_nodes, addr); tipc_bclink_unlock(net); } @@ -108,11 +177,11 @@ void tipc_bclink_remove_node(struct net *net, u32 addr) struct tipc_net *tn = net_generic(net, tipc_net_id); tipc_bclink_lock(net); - tipc_nmap_remove(&tn->bclink->bcast_nodes, addr); + tipc_nmap_remove(&tn->bcbase->bcast_nodes, addr); /* Last node? => reset backlog queue */ - if (!tn->bclink->bcast_nodes.count) - tipc_link_purge_backlog(&tn->bclink->link); + if (!tn->bcbase->bcast_nodes.count) + tipc_link_purge_backlog(&tn->bcbase->link); tipc_bclink_unlock(net); } @@ -147,7 +216,7 @@ struct tipc_node *tipc_bclink_retransmit_to(struct net *net) { struct tipc_net *tn = net_generic(net, tipc_net_id); - return tn->bclink->retransmit_to; + return tn->bcbase->retransmit_to; } /** @@ -241,7 +310,7 @@ void tipc_bclink_acknowledge(struct tipc_node *n_ptr, u32 acked) * acknowledge sent messages only (if other nodes still exist) * or both sent and unsent messages (otherwise) */ - if (tn->bclink->bcast_nodes.count) + if (tn->bcbase->bcast_nodes.count) acked = tn->bcl->silent_intv_cnt; else acked = tn->bcl->snd_nxt; @@ -390,18 +459,18 @@ static void bclink_peek_nack(struct net *net, struct tipc_msg *msg) tipc_node_put(n_ptr); } -/* tipc_bclink_xmit - deliver buffer chain to all nodes in cluster +/* tipc_bcast_xmit - deliver buffer chain to all nodes in cluster * and to identified node local sockets * @net: the applicable net namespace * @list: chain of buffers containing message * Consumes the buffer chain, except when returning -ELINKCONG * Returns 0 if success, otherwise errno: -ELINKCONG,-EHOSTUNREACH,-EMSGSIZE */ -int tipc_bclink_xmit(struct net *net, struct sk_buff_head *list) +int tipc_bcast_xmit(struct net *net, struct sk_buff_head *list) { struct tipc_net *tn = net_generic(net, tipc_net_id); struct tipc_link *bcl = tn->bcl; - struct tipc_bclink *bclink = tn->bclink; + struct tipc_bc_base *bclink = tn->bcbase; int rc = 0; int bc = 0; struct sk_buff *skb; @@ -508,7 +577,7 @@ void tipc_bclink_rcv(struct net *net, struct sk_buff *buf) tipc_bclink_acknowledge(node, msg_bcast_ack(msg)); tipc_bclink_lock(net); bcl->stats.recv_nacks++; - tn->bclink->retransmit_to = node; + tn->bcbase->retransmit_to = node; bclink_retransmit_pkt(tn, msg_bcgap_after(msg), msg_bcgap_to(msg)); tipc_bclink_unlock(net); @@ -524,8 +593,8 @@ void tipc_bclink_rcv(struct net *net, struct sk_buff *buf) /* Handle in-sequence broadcast message */ seqno = msg_seqno(msg); next_in = mod(node->bclink.last_in + 1); - arrvq = &tn->bclink->arrvq; - inputq = &tn->bclink->inputq; + arrvq = &tn->bcbase->arrvq; + inputq = &tn->bcbase->inputq; if (likely(seqno == next_in)) { receive: @@ -651,7 +720,7 @@ static int tipc_bcbearer_send(struct net *net, struct sk_buff *buf, struct tipc_msg *msg = buf_msg(buf); struct tipc_net *tn = net_generic(net, tipc_net_id); struct tipc_bcbearer *bcbearer = tn->bcbearer; - struct tipc_bclink *bclink = tn->bclink; + struct tipc_bc_base *bclink = tn->bcbase; /* Prepare broadcast link message for reliable transmission, * if first time trying to send it; @@ -940,11 +1009,11 @@ int tipc_nl_bc_link_set(struct net *net, struct nlattr *attrs[]) return tipc_bclink_set_queue_limits(net, win); } -int tipc_bclink_init(struct net *net) +int tipc_bcast_init(struct net *net) { struct tipc_net *tn = net_generic(net, tipc_net_id); struct tipc_bcbearer *bcbearer; - struct tipc_bclink *bclink; + struct tipc_bc_base *bclink; struct tipc_link *bcl; bcbearer = kzalloc(sizeof(*bcbearer), GFP_ATOMIC); @@ -981,12 +1050,12 @@ int tipc_bclink_init(struct net *net) msg_set_prevnode(bcl->pmsg, tn->own_addr); strlcpy(bcl->name, tipc_bclink_name, TIPC_MAX_LINK_NAME); tn->bcbearer = bcbearer; - tn->bclink = bclink; + tn->bcbase = bclink; tn->bcl = bcl; return 0; } -void tipc_bclink_stop(struct net *net) +void tipc_bcast_stop(struct net *net) { struct tipc_net *tn = net_generic(net, tipc_net_id); @@ -997,7 +1066,7 @@ void tipc_bclink_stop(struct net *net) RCU_INIT_POINTER(tn->bearer_list[BCBEARER], NULL); synchronize_net(); kfree(tn->bcbearer); - kfree(tn->bclink); + kfree(tn->bcbase); } /** diff --git a/net/tipc/bcast.h b/net/tipc/bcast.h index d74c69bcf60bda5e04ddc61a988afd6fa94bee66..d379b0afe8e8c3a3d1ab20c18361444ce30a03b9 100644 --- a/net/tipc/bcast.h +++ b/net/tipc/bcast.h @@ -37,83 +37,17 @@ #ifndef _TIPC_BCAST_H #define _TIPC_BCAST_H -#include -#include "link.h" -#include "node.h" - -/** - * struct tipc_bcbearer_pair - a pair of bearers used by broadcast link - * @primary: pointer to primary bearer - * @secondary: pointer to secondary bearer - * - * Bearers must have same priority and same set of reachable destinations - * to be paired. - */ - -struct tipc_bcbearer_pair { - struct tipc_bearer *primary; - struct tipc_bearer *secondary; -}; - -#define BCBEARER MAX_BEARERS - -/** - * struct tipc_bcbearer - bearer used by broadcast link - * @bearer: (non-standard) broadcast bearer structure - * @media: (non-standard) broadcast media structure - * @bpairs: array of bearer pairs - * @bpairs_temp: temporary array of bearer pairs used by tipc_bcbearer_sort() - * @remains: temporary node map used by tipc_bcbearer_send() - * @remains_new: temporary node map used tipc_bcbearer_send() - * - * Note: The fields labelled "temporary" are incorporated into the bearer - * to avoid consuming potentially limited stack space through the use of - * large local variables within multicast routines. Concurrent access is - * prevented through use of the spinlock "bclink_lock". - */ -struct tipc_bcbearer { - struct tipc_bearer bearer; - struct tipc_media media; - struct tipc_bcbearer_pair bpairs[MAX_BEARERS]; - struct tipc_bcbearer_pair bpairs_temp[TIPC_MAX_LINK_PRI + 1]; - struct tipc_node_map remains; - struct tipc_node_map remains_new; -}; - -/** - * struct tipc_bclink - link used for broadcast messages - * @lock: spinlock governing access to structure - * @link: (non-standard) broadcast link structure - * @node: (non-standard) node structure representing b'cast link's peer node - * @bcast_nodes: map of broadcast-capable nodes - * @retransmit_to: node that most recently requested a retransmit - * - * Handles sequence numbering, fragmentation, bundling, etc. - */ -struct tipc_bclink { - spinlock_t lock; - struct tipc_link link; - struct tipc_node node; - struct sk_buff_head arrvq; - struct sk_buff_head inputq; - struct tipc_node_map bcast_nodes; - struct tipc_node *retransmit_to; -}; +#include "core.h" struct tipc_node; -extern const char tipc_bclink_name[]; +struct tipc_msg; +struct tipc_nl_msg; +struct tipc_node_map; -/** - * tipc_nmap_equal - test for equality of node maps - */ -static inline int tipc_nmap_equal(struct tipc_node_map *nm_a, - struct tipc_node_map *nm_b) -{ - return !memcmp(nm_a, nm_b, sizeof(*nm_a)); -} +extern const char tipc_bclink_name[]; -int tipc_bclink_init(struct net *net); -void tipc_bclink_stop(struct net *net); +int tipc_bcast_init(struct net *net); +void tipc_bcast_stop(struct net *net); void tipc_bclink_add_node(struct net *net, u32 addr); void tipc_bclink_remove_node(struct net *net, u32 addr); struct tipc_node *tipc_bclink_retransmit_to(struct net *tn); @@ -123,12 +57,12 @@ u32 tipc_bclink_get_last_sent(struct net *net); u32 tipc_bclink_acks_missing(struct tipc_node *n_ptr); void tipc_bclink_update_link_state(struct tipc_node *node, u32 last_sent); -int tipc_bclink_reset_stats(struct net *net); -int tipc_bclink_set_queue_limits(struct net *net, u32 limit); void tipc_bcbearer_sort(struct net *net, struct tipc_node_map *nm_ptr, u32 node, bool action); -uint tipc_bclink_get_mtu(void); -int tipc_bclink_xmit(struct net *net, struct sk_buff_head *list); +int tipc_bclink_reset_stats(struct net *net); +int tipc_bclink_set_queue_limits(struct net *net, u32 limit); +uint tipc_bcast_get_mtu(void); +int tipc_bcast_xmit(struct net *net, struct sk_buff_head *list); void tipc_bclink_wakeup_users(struct net *net); int tipc_nl_add_bc_link(struct net *net, struct tipc_nl_msg *msg); int tipc_nl_bc_link_set(struct net *net, struct nlattr *attrs[]); diff --git a/net/tipc/core.h b/net/tipc/core.h index b96b41eabf121cc8577b65d0ad5bb0727ca5d3f7..e4e9a56de64b53ec925f4e7d27bbb55ba31edbac 100644 --- a/net/tipc/core.h +++ b/net/tipc/core.h @@ -63,7 +63,7 @@ struct tipc_node; struct tipc_bearer; struct tipc_bcbearer; -struct tipc_bclink; +struct tipc_bc_base; struct tipc_link; struct tipc_name_table; struct tipc_server; @@ -94,7 +94,7 @@ struct tipc_net { /* Broadcast link */ struct tipc_bcbearer *bcbearer; - struct tipc_bclink *bclink; + struct tipc_bc_base *bcbase; struct tipc_link *bcl; /* Socket hash table */ diff --git a/net/tipc/net.c b/net/tipc/net.c index d6d1399ae22922754ba24364e21e89a6a3497d22..dc623d5358aa6ae3804ac8de55aa23fd2a314e5f 100644 --- a/net/tipc/net.c +++ b/net/tipc/net.c @@ -117,7 +117,7 @@ int tipc_net_start(struct net *net, u32 addr) tn->own_addr = addr; tipc_named_reinit(net); tipc_sk_reinit(net); - res = tipc_bclink_init(net); + res = tipc_bcast_init(net); if (res) return res; @@ -142,7 +142,7 @@ void tipc_net_stop(struct net *net) tn->own_addr); rtnl_lock(); tipc_bearer_stop(net); - tipc_bclink_stop(net); + tipc_bcast_stop(net); tipc_node_stop(net); rtnl_unlock(); diff --git a/net/tipc/socket.c b/net/tipc/socket.c index 1060d52ff23eb14f7b2ed2f732beacf9a698502c..e2e35b7b1d09a3bc62aa7db4fcbe0342742e5dd6 100644 --- a/net/tipc/socket.c +++ b/net/tipc/socket.c @@ -689,13 +689,13 @@ static int tipc_sendmcast(struct socket *sock, struct tipc_name_seq *seq, msg_set_hdr_sz(mhdr, MCAST_H_SIZE); new_mtu: - mtu = tipc_bclink_get_mtu(); + mtu = tipc_bcast_get_mtu(); rc = tipc_msg_build(mhdr, msg, 0, dsz, mtu, pktchain); if (unlikely(rc < 0)) return rc; do { - rc = tipc_bclink_xmit(net, pktchain); + rc = tipc_bcast_xmit(net, pktchain); if (likely(!rc)) return dsz;